✏️ fix[typo]: Update tutorial-import-stl-named-module.md #4727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code snippets were incorrectly reversed. The snippet "$Env:VCToolsInstallDir\modules\std.ixx" is specific to PowerShell. In PowerShell, environment variables are accessed using the $Env: prefix. The snippet "%VCToolsInstallDir%\modules\std.ixx" is for the Command Prompt (CMD). In CMD, environment variables are enclosed in percent signs (%). So, the original phrase... "If you use PowerShell, substitute "$Env:VCToolsInstallDir\modules\std.ixx" for "%VCToolsInstallDir%\modules\std.ixx" is wrong and should be reversed.
|
@edmund-leibert : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
cpp-language/tech
Change sent to author
visual-cpp/prod
labels
|
Learn Build status updates of commit 67026a8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Feel free to let me know if my correction is incorrect. Other than this minor error, this tutorial was well written. Look forward to hearing your input! 🙂 |
TylerMSFT
approved these changes
Sep 26, 2023
|
#sign-off |
|
#hold-off |
|
Actually, the original is correct. I made the same mistake you did when I read it. |
TylerMSFT
approved these changes
Sep 26, 2023
|
Learn Build status updates of commit 1994036: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
#sign-off |
|
sorry - commented on an unrefreshed page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code snippets were incorrectly reversed.
The snippet
"$Env:VCToolsInstallDir\modules\std.ixx"is specific to PowerShell. In PowerShell, environment variables are accessed using the $Env: prefix.The snippet
"%VCToolsInstallDir%\modules\std.ixx"is for the Command Prompt (CMD). In CMD, environment variables are enclosed in percent signs (%).So, the original phrase...
is wrong and should be reversed to...