Skip to content

Improve example for C2061 #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2023
Merged

Improve example for C2061 #4739

merged 5 commits into from
Oct 20, 2023

Conversation

Rageking8
Copy link
Contributor

Some formatting for the first example together with the addition of a common mistake example (forgot typename when using dependent types).

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b25507b:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2061.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 87e490f:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2061.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Oct 2, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 2, 2023
@TylerMSFT
Update compiler-error-c2061.md
4746686 
It wasn't as clear what the fix using typename was. You can sort it out, but I decided to make it more explicit for those reading quickly.
TylerMSFT
TylerMSFT approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving our examples!

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4746686:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2061.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Copy link
Collaborator

#sign-off

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 50edf5c:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2061.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Jak-MS
Jak-MS reviewed Oct 20, 2023
View reviewed changes
@Jak-MS Jak-MS merged commit b0f23bf into MicrosoftDocs:main Oct 20, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 585e03f:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2061.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Rageking8 Rageking8 deleted the improve-example-for-c2061 branch November 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jak-MS Jak-MS Jak-MS left review comments

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-diagnostics/tech do-not-merge needs-human-review visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rageking8 @Court72 @TylerMSFT @Jak-MS