-
Notifications
You must be signed in to change notification settings - Fork 967
Create alignas
specifier page
#4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create alignas
specifier page
#4742
Conversation
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit ce6f334: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit ee8cd9d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit 33976b5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
@Rageking8 - Thanks for your pull request. A member of the content team will review it. #label:"aq-pr-triaged" |
@Rageking8 , thank you for taking time to improve the docs! Really appreciate it! |
No worries, there is no rush for review and you can always review at the pace you desire. Thanks for the heads up on the publishing process (did not know that it requires more heavy lifting to publish versus just edits)! Happy to review together once you are free. |
@Rageking8, I'm coming back around to this. I'd like to take this content, but I want you to get credit for it. I'm not sure how to do that when I port it to our private repo. Let me see if I can figure anything out about that before I do anything. |
@Rageking8, I've asked around and don't have a good solution for assigning you credit. What I think I'll do is add your public repo fork as a remote to my local private repo and fetch your branch and use it to create a PR in the private repo that I can submit. You good with that? |
Sounds great! Even if credit for the article is not properly assigned, I am fine with that too. Since I am busier now, if you could complete the PRs final stretch, I would highly appreciate it. I will try to help if possible. Thanks. |
Very good. I'll probably do this by adding your branch as a remote and getting the PR through that way. We'll see how it goes. |
@Rageking8, after looking into it more I learned that the preferred approach is to bring your branch over to the private repo, get it to meet our publishing requirements and pass our internal tests, and then publish from the private repo. So that's what I've done. |
Hi @Rageking8, I ported these changes to a branch in the private repo, did an edit pass, did a technical review, and got it merged. |
There exist a page for
alignof
Operator but they does not seem to be one foralignas
Specifier. The other pages that mentionalignas
does not go into enough depth. The page align cpp focuses on the Microsoft specific version__declspec(align(#))
and is not fully applicable toalignas
. Page alignment cpp declarations on the other hand is more about the concept of alignment and lacks coverage ofalignas
. The C version is different from C++alignas
and some examples are also lacking.Some loose ends need to be tied up to prevent duplicated content and to ensure the relevant pages are properly linked.