Document warning C5267 #4807

Rageking8 · 2023-11-08T14:13:30Z

I accidentally stumbled upon this new warning code by misreading the following sentence as it "emitting a warning" (instead of it not emitting, as shown below)

cpp-docs/docs/cpp/explicitly-defaulted-and-deleted-functions.md

Line 39 in 02e1daf

    
           > In both cases, Visual Studio continues to automatically generate the necessary functions implicitly, and does not emit a warning.

So this PR just documented this relatively new warning code.

prmerger-automator · 2023-11-08T14:13:39Z

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

learn-build-service-prod · 2023-11-08T14:16:31Z

Learn Build status updates of commit bc69614:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/c5267.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

prmerger-automator · 2023-11-08T14:16:35Z

PRMerger Results

Issue	Description
Added File(s)	This PR contains added files. New files require human review.
Yaml File(s)	This PR includes changes to .yml file(s) owned by another author.
File Change Percent	This PR contains file(s) with more than 30% file change.

Court72 · 2023-11-08T15:43:50Z

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

TylerMSFT · 2023-11-08T19:22:38Z

@Rageking8, thanks! Appreciate the new documentation.
I have a number of new articles I need to write, so it may be a bit before I can get to reviewing this and integrating it into the docs. I will loop back to this when I can. The dev team frequently writes drafts for the new warning topics. I'll need to check that this doesn't duplicate their efforts. Take care.

TylerMSFT · 2023-11-09T18:34:46Z

@Rageking8, I ran this past the dev team and they weren't already working on it, so we'll be pleased to take this contribution. And they are aware that this exists so they won't go off now and duplicate the effort. Thank you! I'm getting ready for a release so I have to focus on some other content for a few days. Then I'll come back to this. Thanks for adding to the docs!

edits

learn-build-service-prod · 2023-11-13T22:07:49Z

Learn Build status updates of commit fb48724:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/c5267.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

prmerger-automator · 2023-11-13T22:07:52Z

PRMerger Results

Issue	Description
Added File(s)	This PR contains added files. New files require human review.
Yaml File(s)	This PR includes changes to .yml file(s) owned by another author.
File Change Percent	This PR contains file(s) with more than 30% file change.

edit

learn-build-service-prod · 2023-11-13T22:21:36Z

Learn Build status updates of commit 9229c41:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/c5267.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

prmerger-automator · 2023-11-13T22:21:40Z

PRMerger Results

Issue	Description
Added File(s)	This PR contains added files. New files require human review.
Yaml File(s)	This PR includes changes to .yml file(s) owned by another author.
File Change Percent	This PR contains file(s) with more than 30% file change.

Hopefully clarify that although it is decpreated, it is still supported.

learn-build-service-prod · 2023-11-14T19:11:47Z

Learn Build status updates of commit 10c0b21:

⚠️ Validation status: warnings

File	Status	Details
docs/error-messages/compiler-warnings/c5267.md	⚠️Warning	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

learn-build-service-prod · 2023-11-14T19:14:21Z

Learn Build status updates of commit 829ad6e:

⚠️ Validation status: warnings

File	Status	Details
docs/error-messages/compiler-warnings/c5267.md	⚠️Warning	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

last edits

TylerMSFT

Thanks, @Rageking8!

learn-build-service-prod · 2023-11-14T20:25:59Z

Learn Build status updates of commit c40ec45:

⚠️ Validation status: warnings

File	Status	Details
docs/error-messages/compiler-warnings/c5267.md	⚠️Warning	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

docs/error-messages/compiler-warnings/c5267.md

Line 18, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '[https://eel.is/c++draft/depr.impldec](https://eel.is/c++draft/depr.impldec'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

fix link

learn-build-service-prod · 2023-11-14T20:31:51Z

Learn Build status updates of commit 44140ab:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/cpp/explicitly-defaulted-and-deleted-functions.md	✅Succeeded
docs/error-messages/compiler-warnings/c5267.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-by-compiler-version.md	✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md	✅Succeeded
docs/error-messages/toc.yml	✅Succeeded
docs/preprocessor/compiler-warnings-that-are-off-by-default.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

prmerger-automator · 2023-11-14T20:31:55Z

PRMerger Results

Issue	Description
Added File(s)	This PR contains added files. New files require human review.
Yaml File(s)	This PR includes changes to .yml file(s) owned by another author.
File Change Percent	This PR contains file(s) with more than 30% file change.

TylerMSFT · 2023-11-14T21:43:28Z

#sign-off

Jak-MS · 2023-11-14T22:00:41Z

@TylerMSFT - because this PR includes a new article, the commits will need to be moved to the private repo so we can review on staging. can you move them or would you like our assistance?

Jak-MS · 2023-11-14T22:00:56Z

#hold-off

TylerMSFT · 2023-11-14T22:19:19Z

@Jak-MS - could you be so kind as to move it over to our private repo?

TylerMSFT · 2023-11-14T23:54:50Z

@Rageking8, because of the new article, I must port this PR over to the private repo, where we do additional validation. I've ported the PR over, and am working through getting it published.
We can close this now. Your work is in the private repo now.
Thanks for giving us a new warning topic!

TylerMSFT · 2023-11-15T20:10:24Z

@Rageking8, I got this ported. It should be live by tomorrow. Thanks for the content!

Document warning C5267

bc69614

prmerger-automator bot added the do-not-merge label Nov 8, 2023

prmerger-automator bot requested a review from TylerMSFT November 8, 2023 14:13

prmerger-automator bot assigned TylerMSFT Nov 8, 2023

prmerger-automator bot added Change sent to author cpp-language/tech visual-cpp/prod labels Nov 8, 2023

prmerger-automator bot added the needs-human-review label Nov 8, 2023

prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 8, 2023

Rastaban approved these changes Nov 8, 2023

View reviewed changes

Update c5267.md

fb48724

edits

Update compiler-warnings-by-compiler-version.md

9229c41

edit

TylerMSFT added 3 commits November 14, 2023 11:08

Update c5267.md

10c0b21

Hopefully clarify that although it is decpreated, it is still supported.

Update c5267.md

829ad6e

Update c5267.md

d06090a

Update c5267.md

c40ec45

last edits

TylerMSFT approved these changes Nov 14, 2023

View reviewed changes

Update c5267.md

44140ab

fix link

prmerger-automator bot added ready-to-merge and removed do-not-merge labels Nov 14, 2023

prmerger-automator bot added do-not-merge and removed ready-to-merge labels Nov 14, 2023

TylerMSFT closed this Nov 14, 2023

Rageking8 deleted the document-warning-c5267 branch November 16, 2023 01:47

Document warning C5267 #4807

Document warning C5267 #4807

Uh oh!

Conversation

Rageking8 commented Nov 8, 2023

Uh oh!

prmerger-automator bot commented Nov 8, 2023

Uh oh!

learn-build-service-prod bot commented Nov 8, 2023

✅ Validation status: passed

Uh oh!

prmerger-automator bot commented Nov 8, 2023

PRMerger Results

Uh oh!

Court72 commented Nov 8, 2023

Uh oh!

TylerMSFT commented Nov 8, 2023

Uh oh!

TylerMSFT commented Nov 9, 2023

Uh oh!

learn-build-service-prod bot commented Nov 13, 2023

✅ Validation status: passed

Uh oh!

prmerger-automator bot commented Nov 13, 2023

PRMerger Results

Uh oh!

learn-build-service-prod bot commented Nov 13, 2023

✅ Validation status: passed

Uh oh!

prmerger-automator bot commented Nov 13, 2023

PRMerger Results

Uh oh!

learn-build-service-prod bot commented Nov 14, 2023

⚠️ Validation status: warnings

docs/error-messages/compiler-warnings/c5267.md

Uh oh!

learn-build-service-prod bot commented Nov 14, 2023

⚠️ Validation status: warnings

docs/error-messages/compiler-warnings/c5267.md

Uh oh!

TylerMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

learn-build-service-prod bot commented Nov 14, 2023

⚠️ Validation status: warnings

docs/error-messages/compiler-warnings/c5267.md

Uh oh!

learn-build-service-prod bot commented Nov 14, 2023

✅ Validation status: passed

Uh oh!

prmerger-automator bot commented Nov 14, 2023

PRMerger Results

Uh oh!

TylerMSFT commented Nov 14, 2023

Uh oh!

Jak-MS commented Nov 14, 2023

Uh oh!

Jak-MS commented Nov 14, 2023

Uh oh!

TylerMSFT commented Nov 14, 2023

Uh oh!

TylerMSFT commented Nov 14, 2023

Uh oh!

TylerMSFT commented Nov 15, 2023

Uh oh!

Uh oh!