Skip to content

Fix incorrect quotation marks in Inline functions (C++) #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

codeworm96
Copy link
Contributor

This PR fixes incorrect quotation marks in Inline functions (C++):

  • "a," -> "a",
  • "z." -> "z".

Signed-off-by: Yuning Zhang <[email protected]>
Copy link
Contributor

@codeworm96 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 1dd2c9d:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/inline-functions-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeworm96
LOL. This is not the place for the American practice of putting the punctuation inside the close-quote. Good catch!

However, this will also work better if the double-quotes are replaced by single quotes as code literals, since we are talking about single char values (i.e., 'a' and 'z') eliminating any grammar disagreement.

@Court72
Copy link
Contributor

Court72 commented Nov 24, 2023

@TylerMSFT

Can you review the proposed changes and this comment from @orcmid?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 24, 2023
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How funny. This may have been done by someone who was slavishly following suggestions from our grammar tooling, who didn't understand the context.
Thanks for fixing this.

Went for a super literal reading of what we are comparing against.
Copy link
Contributor

Learn Build status updates of commit 8f1c441:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/inline-functions-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt ShannonLeavitt merged commit 40b09b3 into MicrosoftDocs:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants