-
Notifications
You must be signed in to change notification settings - Fork 967
Fix incorrect quotation marks in Inline functions (C++)
#4829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yuning Zhang <[email protected]>
@codeworm96 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 1dd2c9d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeworm96
LOL. This is not the place for the American practice of putting the punctuation inside the close-quote. Good catch!
However, this will also work better if the double-quotes are replaced by single quotes as code literals, since we are talking about single char values (i.e., 'a'
and 'z'
) eliminating any grammar disagreement.
Can you review the proposed changes and this comment from @orcmid? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How funny. This may have been done by someone who was slavishly following suggestions from our grammar tooling, who didn't understand the context.
Thanks for fixing this.
Went for a super literal reading of what we are comparing against.
Learn Build status updates of commit 8f1c441: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#sign-off |
This PR fixes incorrect quotation marks in
Inline functions (C++)
: