Skip to content

Fix invalid nodiscard attribute #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix invalid nodiscard attribute #4862

merged 1 commit into from
Jan 4, 2024

Conversation

Rageking8
Copy link
Contributor

nodiscard attribute with only 1 set of square brackets is not valid, neither is the all caps version.

@prmerger-automator PRMerger Automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 6c3bef6:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/ambiguous-local-time.md ✅Succeeded
docs/standard-library/nonexistent-local-time.md ✅Succeeded
docs/standard-library/subrange-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 26, 2023

@TylerMSFT

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 26, 2023
TylerMSFT
TylerMSFT approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rageking8. Happy 2024 to you.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit b880694 into MicrosoftDocs:main Jan 4, 2024
@Rageking8 Rageking8 deleted the fix-invalid-nodiscard-attribute branch January 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-standard-libraries/tech qualifies-for-auto-merge ready-to-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rageking8 @Jak-MS @TylerMSFT @Court72