Skip to content

Standardize C++ version naming #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rageking8
Copy link
Contributor

The canonical way to represent a C++ version (only the last 2 digits of the year) is without the extra space character (i.e. either C++20 or C++ 2020). This PR removes all extra spaces as the canonical version is more prevalent in this docs repository and is used as such in the official ISO website.


// 18) time_zone_link
bool operator==(const time_zone_link& Left, const time_zone_link& Right) noexcept;
bool operator==(const time_zone_link& Left, const time_zone_link& Right) noexcept; // C++20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the C++20 label, added it as a drive-by.

Copy link
Contributor

Learn Build status updates of commit cbaebf8:

✅ Validation status: passed

File Status Preview URL Details
docs/build/walkthrough-header-units.md ✅Succeeded
docs/cpp/align-cpp.md ✅Succeeded
docs/cpp/compiler-limits.md ✅Succeeded
docs/cpp/function-call-operator-parens.md ✅Succeeded
docs/cpp/functions-cpp.md ✅Succeeded
docs/cpp/lambda-expressions-in-cpp.md ✅Succeeded
docs/cpp/namespaces-cpp.md ✅Succeeded
docs/cpp/nonstandard-behavior.md ✅Succeeded
docs/cpp/user-defined-literals-cpp.md ✅Succeeded
docs/error-messages/compiler-errors-2/compiler-error-c2956.md ✅Succeeded
docs/error-messages/compiler-warnings/c4834.md ✅Succeeded
docs/standard-library/ambiguous-local-time.md ✅Succeeded
docs/standard-library/basic-istream-view-class.md ✅Succeeded
docs/standard-library/choose-enum.md ✅Succeeded
docs/standard-library/chrono-functions.md ✅Succeeded
docs/standard-library/chrono-literals.md ✅Succeeded
docs/standard-library/chrono-operators.md ✅Succeeded
docs/standard-library/common-view-class.md ✅Succeeded
docs/standard-library/day-class.md ✅Succeeded
docs/standard-library/drop-view-class.md ✅Succeeded
docs/standard-library/drop-while-view-class.md ✅Succeeded
docs/standard-library/elements-view-class.md ✅Succeeded
docs/standard-library/empty-view-class.md ✅Succeeded
docs/standard-library/filter-view-class.md ✅Succeeded
docs/standard-library/iota-view-class.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 26, 2023

@TylerMSFT - is this yours to review? If not, you can reassign or let me know who to assign. Thanks!

  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 26, 2023
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup - thanks @Rageking8

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit a61d6a8 into MicrosoftDocs:main Jan 4, 2024
@Rageking8 Rageking8 deleted the standardize-cpp-version-naming branch January 17, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged Tracking label for the PR review team needs-human-review ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants