Skip to content

Address mistakes in inline functions cpp #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rageking8
Copy link
Contributor

Fixes #4871

Tidy up some of the earlier examples, augmented the multiply example to be more explicit about the differences when using a function macro like a proper function. For the last example, there seems to be UB with sqr(c++) which expands to ((c++) * (c++)), hence I wrapped it away into a function and added the part about the inline function square.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8016acc:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/inline-functions-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Jan 2, 2024

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jan 2, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff - thanks @Rageking8!

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit 9d8e9e6 into MicrosoftDocs:main Jan 17, 2024
@Rageking8 Rageking8 deleted the address-mistakes-in-inline-functions-cpp branch February 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in inline functions page
3 participants