Skip to content

Updated the linter settings image. #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

MryamGirmay
Copy link
Contributor

I have updated the image for linter setting, so it lines up with the updated setting in Visual Studio. There are some docs that have this image referenced but the image wasn't displaying the right information.

Copy link
Contributor

Learn Build status updates of commit fbf2ada:

✅ Validation status: passed

File Status Preview URL Details
docs/ide/media/linter-settings.png ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Image File This PR added or updated an image file(s).

@ShannonLeavitt
Copy link
Contributor

@TylerMSFT

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 2, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@MryamGirmay
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@TylerMSFT
Copy link
Collaborator

@ShannonLeavitt , the system isn't allowing us to #sign-off. Do you know what the deal is? I own the docs in this directory.

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@TylerMSFT TylerMSFT merged commit f898db9 into MicrosoftDocs:main Feb 3, 2024
@ShannonLeavitt
Copy link
Contributor

@TylerMSFT - Looks like this might have been a one-off problem rooted in the fact that the image file has no author that GitHub recognizes. In cases like this, you can email the publicprs alias for merge assistance.

@TylerMSFT
Copy link
Collaborator

TylerMSFT commented Feb 5, 2024

@ShannonLeavitt , interesting. How do I set the author for an image?

@ShannonLeavitt
Copy link
Contributor

@TylerMSFT - I don't think there's a way to do that. Fortunately, image-only PRs are rare; when these PRs pop up we can manually assign and merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants