Skip to content

Remove extra trailing comma in istream iterator #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

A trailing comma at the end of the template parameter list is an error.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 0c41b7b:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/istream-iterator-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Mar 1, 2024

@TylerMSFT

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Mar 1, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True - thanks for fixing that.

@TylerMSFT
Copy link
Collaborator

#sign-off

@TylerMSFT TylerMSFT merged commit c748c53 into MicrosoftDocs:main Mar 1, 2024
learn-build-service-prod bot added a commit that referenced this pull request Mar 2, 2024
* Fixes #3014

* Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#5198)

* largeaddressaware:no is not recommended for 64-bit apps

* Update connect-to-your-remote-linux-computer.md

Removing references to RSA/DSA keys due to security concerns

* Update largeaddressaware-handle-large-addresses.md

* Update largeaddressaware-handle-large-addresses.md

* Update largeaddressaware-handle-large-addresses.md

* Fixed syntax error in example message

* Update clang-tidy.md

Adding support for CMake Presets

* Update clang-tidy.md

addressing some feedback

* Update assignment-operators.md

Clarify built-in behaviour for compound assignment.
Add mention of overloaded compound assignment operators
Fixes #4745

* Update gmtime-s-gmtime32-s-gmtime64-s.md

Remove note about daylight savings time, as these functions convert from time-since-epoch to UTC, neither of which are affected by daylight savings

* Update gmtime-gmtime32-gmtime64.md

* Correct JSON output of sourcedependencies.md

Updates the version number in the JSON to the one currently used by the compiler, and removes the bogus ImportedHeaderUnit entry

* update date

* Update gmtime-gmtime32-gmtime64.md

update ms.date

* Update gmtime-s-gmtime32-s-gmtime64-s.md

update date

* Update assignment-operators.md

update ms.date

* Repo sync for protected branch (#4958)

* add link to backend improvements

* change feedback system from github issues to the new UUF system (#5208)

Co-authored-by: TylerMSFT <[email protected]>

* new article: include diagnostics
* acrolinx and edit
* acrolinx
* small edits
* clarified specific to C++
* clarify that this is C++ include diagnostics
* fix github #4953

---------

Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: Tyler Whitney <[email protected]>
Co-authored-by: Phil <[email protected]>
Co-authored-by: James Barnett <[email protected]>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]>

* Update clang-tidy.md

* Update clang-tidy.md

* Update clang-tidy.md

* header casing & markdown syntax tweaks

* Update docs/code-quality/clang-tidy.md

* Fix built-in operators toc yml

* Update subscript-operator.md

* Update left-shift-and-right-shift-operators-input-and-output.md

* Update subscript-operator.md

* Improve C2548 (#4964)

* Improve C2548

* Update compiler-error-c2548.md

* Update compiler-error-c2548.md

fixed title casing

* Update compiler-error-c2548.md

typo

---------

Co-authored-by: Tyler Whitney <[email protected]>

* Remove extra trailing comma in istream iterator (#4962)

* Make built-in operators title consistent (#4963)

* Fixes #3014 (#5221)

Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>

---------

Co-authored-by: mspll <[email protected]>
Co-authored-by: Sinem Akinci <[email protected]>
Co-authored-by: Phil <[email protected]>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Alma Jenks <[email protected]>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]>
Co-authored-by: Tyler Whitney <[email protected]>
Co-authored-by: Courtney Wales <[email protected]>
Co-authored-by: Jak Koke <[email protected]>
Co-authored-by: Javad Kouchakzadeh <[email protected]>
Co-authored-by: Sy Brand <[email protected]>
Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: James Barnett <[email protected]>
Co-authored-by: Rageking8 <[email protected]>
Co-authored-by: Taojunshen <[email protected]>

---------

Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: mspll <[email protected]>
Co-authored-by: Sinem Akinci <[email protected]>
Co-authored-by: Phil <[email protected]>
Co-authored-by: Alma Jenks <[email protected]>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]>
Co-authored-by: Tyler Whitney <[email protected]>
Co-authored-by: Courtney Wales <[email protected]>
Co-authored-by: Jak Koke <[email protected]>
Co-authored-by: Javad Kouchakzadeh <[email protected]>
Co-authored-by: Sy Brand <[email protected]>
Co-authored-by: James Barnett <[email protected]>
Co-authored-by: Rageking8 <[email protected]>
@Rageking8 Rageking8 deleted the remove-extra-trailing-comma-in-istream-iterator branch March 3, 2024 10:29
learn-build-service-prod bot added a commit that referenced this pull request Mar 4, 2024
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#5198)

* largeaddressaware:no is not recommended for 64-bit apps

* Update connect-to-your-remote-linux-computer.md

Removing references to RSA/DSA keys due to security concerns

* Update largeaddressaware-handle-large-addresses.md

* Update largeaddressaware-handle-large-addresses.md

* Update largeaddressaware-handle-large-addresses.md

* Fixed syntax error in example message

* Update clang-tidy.md

Adding support for CMake Presets

* Update clang-tidy.md

addressing some feedback

* Update assignment-operators.md

Clarify built-in behaviour for compound assignment.
Add mention of overloaded compound assignment operators
Fixes #4745

* Update gmtime-s-gmtime32-s-gmtime64-s.md

Remove note about daylight savings time, as these functions convert from time-since-epoch to UTC, neither of which are affected by daylight savings

* Update gmtime-gmtime32-gmtime64.md

* Correct JSON output of sourcedependencies.md

Updates the version number in the JSON to the one currently used by the compiler, and removes the bogus ImportedHeaderUnit entry

* update date

* Update gmtime-gmtime32-gmtime64.md

update ms.date

* Update gmtime-s-gmtime32-s-gmtime64-s.md

update date

* Update assignment-operators.md

update ms.date

* Repo sync for protected branch (#4958)

* add link to backend improvements

* change feedback system from github issues to the new UUF system (#5208)

Co-authored-by: TylerMSFT <[email protected]>

* new article: include diagnostics
* acrolinx and edit
* acrolinx
* small edits
* clarified specific to C++
* clarify that this is C++ include diagnostics
* fix github #4953

---------

Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: Tyler Whitney <[email protected]>
Co-authored-by: Phil <[email protected]>
Co-authored-by: James Barnett <[email protected]>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]>

* Update clang-tidy.md

* Update clang-tidy.md

* Update clang-tidy.md

* header casing & markdown syntax tweaks

* Update docs/code-quality/clang-tidy.md

* Fix built-in operators toc yml

* Update subscript-operator.md

* Update left-shift-and-right-shift-operators-input-and-output.md

* Update subscript-operator.md

* Improve C2548 (#4964)

* Improve C2548

* Update compiler-error-c2548.md

* Update compiler-error-c2548.md

fixed title casing

* Update compiler-error-c2548.md

typo

---------

Co-authored-by: Tyler Whitney <[email protected]>

* Remove extra trailing comma in istream iterator (#4962)

* Make built-in operators title consistent (#4963)

* Fixes #3014 (#5221)

Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>

---------

Co-authored-by: mspll <[email protected]>
Co-authored-by: Sinem Akinci <[email protected]>
Co-authored-by: Phil <[email protected]>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Alma Jenks <[email protected]>
Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]>
Co-authored-by: Tyler Whitney <[email protected]>
Co-authored-by: Courtney Wales <[email protected]>
Co-authored-by: Jak Koke <[email protected]>
Co-authored-by: Javad Kouchakzadeh <[email protected]>
Co-authored-by: Sy Brand <[email protected]>
Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: James Barnett <[email protected]>
Co-authored-by: Rageking8 <[email protected]>
Co-authored-by: Taojunshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants