Skip to content

Improve C2751 #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Improve C2751 #4981

merged 1 commit into from
Mar 11, 2024

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Mar 11, 2024

Fix a few issues:

  • Missing /c flag
  • Adding definitions to the std namespace is UB
  • Superfluous C2955 (use of class template requires template argument list) error

Overall, the example is now slightly simpler.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit a4290ab:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2751.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit 814f892 into MicrosoftDocs:main Mar 11, 2024
@Rageking8 Rageking8 deleted the improve-c2751 branch March 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants