Skip to content

Capitalize error code #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

Rageking8
Copy link
Contributor

The "C" in error codes should be capitalized.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Comment on lines 2 to 3
description: "Learn more about: Compiler Warning (level 4) C4389"
title: "Compiler Warning (level 4) C4389"
description: "Microsoft C/C++ compiler warning C4389, its causes and resolution."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalized this description.

Copy link
Contributor

Learn Build status updates of commit cdeaf2b:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2128.md ✅Succeeded
docs/error-messages/compiler-errors-1/fatal-error-c1192.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-c5072.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-3-c4534.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-4-c4254.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-4-c4389.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@ShannonLeavitt
Copy link
Contributor

@TylerMSFT

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Mar 18, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - thank you

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator prmerger-automator bot requested a review from TylerMSFT March 18, 2024 17:52
@Jak-MS Jak-MS merged commit 01a5c81 into MicrosoftDocs:main Mar 18, 2024
Copy link
Contributor

Learn Build status updates of commit d8aed4b:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-1/compiler-error-c2128.md ✅Succeeded
docs/error-messages/compiler-errors-1/fatal-error-c1192.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-c5072.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-3-c4534.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-4-c4254.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warning-level-4-c4389.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@Rageking8 Rageking8 deleted the capitalize-error-code branch March 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants