Skip to content

Split C5000+ warning list #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Rageking8
Copy link
Contributor

Summary:

  • Split C5000+ warning range into 2 new articles (C5000-C5199 and C5200-C5399).
  • This standardizes the range of 200 warnings per article and fix the mismatch where compiler-warnings-c4800-through-c4999.md covers range C4800-C5999.

Note 1) One side effect include the new minor mismatch where compiler-warnings-c4000-c5999.md now only covers till C5399.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit abd9dbc:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-warnings/compiler-warnings-c4000-c5999.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c5000-through-c5199.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c5200-through-c5399.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 4275b58:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-warnings/compiler-warnings-c4000-c5999.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c4800-through-c4999.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c5000-through-c5199.md ✅Succeeded
docs/error-messages/compiler-warnings/compiler-warnings-c5200-through-c5399.md ✅Succeeded
docs/error-messages/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Apr 17, 2024

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Apr 17, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for factoring these out!
There is a bunch of editing going on in this general area by one of the compiler devs. I hope you don't run into a ton of merge conflicts merging this.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS
Copy link
Contributor

Jak-MS commented Apr 18, 2024

@TylerMSFT - because this PR contains new articles, we can't merge it here in the public repo. The commits will have to be moved to the private repo and reviewed there (where we have access to better tools). Can you move the commits and open a PR there? Let us know if you'd like assistance.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Rastaban
Copy link
Contributor

Thank you for factoring these out! There is a bunch of editing going on in this general area by one of the compiler devs. I hope you don't run into a ton of merge conflicts merging this.

I am making my way up from the lower numbered warnings with my edits, so I don't expect to have much conflict up at the 5000+ level. This should make my changes a little easier when I get up there though.

@TylerMSFT
Copy link
Collaborator

TylerMSFT commented Apr 18, 2024 via email

@TylerMSFT
Copy link
Collaborator

I'll port the changes to the private repo and submit the PR that way.

@TylerMSFT
Copy link
Collaborator

Hey @Rageking8 , I ported your work, and did some SEO and description cleanup. PR #5555 just merged, so the work you did here is in and will be live on Monday.
Thanks again for improving the quality of life for C++ doc readers.

@TylerMSFT TylerMSFT closed this Apr 19, 2024
@Rageking8 Rageking8 deleted the split-c5000+-warning-list branch May 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants