-
Notifications
You must be signed in to change notification settings - Fork 967
Split C5000+ warning list #5023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit abd9dbc: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit 4275b58: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for factoring these out!
There is a bunch of editing going on in this general area by one of the compiler devs. I hope you don't run into a ton of merge conflicts merging this.
#sign-off |
@TylerMSFT - because this PR contains new articles, we can't merge it here in the public repo. The commits will have to be moved to the private repo and reviewed there (where we have access to better tools). Can you move the commits and open a PR there? Let us know if you'd like assistance. #label:"aq-pr-triaged" |
I am making my way up from the lower numbered warnings with my edits, so I don't expect to have much conflict up at the 5000+ level. This should make my changes a little easier when I get up there though. |
[like] Tyler Whitney reacted to your message:
…________________________________
From: Phil Christensen ***@***.***>
Sent: Thursday, April 18, 2024 10:00:43 PM
To: MicrosoftDocs/cpp-docs ***@***.***>
Cc: Tyler Whitney ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/cpp-docs] Split C5000+ warning list (PR #5023)
Thank you for factoring these out! There is a bunch of editing going on in this general area by one of the compiler devs. I hope you don't run into a ton of merge conflicts merging this.
I am making my way up from the lower numbered warnings with my edits, so I don't expect to have much conflict up at the 5000+ level. This should make my changes a little easier when I get up there though.
—
Reply to this email directly, view it on GitHub<#5023 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC54FH2RLQLZ76F3ENCO7PDY6A7AXAVCNFSM6AAAAABGKNWFGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGM4TOMRRGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I'll port the changes to the private repo and submit the PR that way. |
Hey @Rageking8 , I ported your work, and did some SEO and description cleanup. PR #5555 just merged, so the work you did here is in and will be live on Monday. |
Summary:
compiler-warnings-c4800-through-c4999.md
covers range C4800-C5999.Note 1) One side effect include the new minor mismatch where
compiler-warnings-c4000-c5999.md
now only covers till C5399.