Skip to content

Update arm64-intrinsics.md to include intrin.h mention #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

janisozaur
Copy link
Contributor

Some intrinsics, such as __prefetch come from intrin.h header file.

Some intrinsics, such as `__prefetch` come from `intrin.h` header file.
Copy link
Contributor

@janisozaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit cd4fa5a:

✅ Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 25, 2024

@sigatrev

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Apr 25, 2024
@sigatrev
Copy link
Contributor

sigatrev commented Apr 25, 2024

This change implies that some neon intrinsics are included through intrin.h which is not correct. The intrinsics listed explicitly on that page are the intrinsics that are not neon.

I do agree that we should mention the header to include for those intrinsics, but probably with a note under the ARM64-specific intrinsics listing header, rather than under the Neon header.

tech review feedback
Copy link
Contributor

Learn Build status updates of commit 45db299:

✅ Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 2733260:

✅ Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT
Copy link
Collaborator

@sigatrev - I updated per your feedback.

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

Copy link
Contributor

@sigatrev sigatrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @TylerMSFT

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

@TylerMSFT TylerMSFT merged commit da08769 into MicrosoftDocs:main Jun 21, 2024
2 checks passed
@janisozaur janisozaur deleted the patch-1 branch June 22, 2024 16:48
@janisozaur
Copy link
Contributor Author

Thanks for getting this merged, hopefully more software gets ported to neon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants