-
Notifications
You must be signed in to change notification settings - Fork 967
Update arm64-intrinsics.md to include intrin.h mention #5028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some intrinsics, such as `__prefetch` come from `intrin.h` header file.
@janisozaur : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit cd4fa5a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
This change implies that some neon intrinsics are included through I do agree that we should mention the header to include for those intrinsics, but probably with a note under the |
tech review feedback
tech review
Learn Build status updates of commit 45db299: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2733260: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@sigatrev - I updated per your feedback. |
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @TylerMSFT
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev |
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev |
Thanks for getting this merged, hopefully more software gets ported to neon |
Some intrinsics, such as
__prefetch
come fromintrin.h
header file.