Skip to content

Add compiler option /feature and update the /arch (ARM64) option #5036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented May 15, 2024

Add the new compiler option /feature. This option enables certain ARM64 architecture features when targeting an Arm A-Profile architecture extension.

Update the arguments of compiler option /arch (ARM64) to include other versions for Arm8-A and Arm9-A. /arch (ARM64) also has the option to include feature arguments used in /feature option.

These changes apply to Visual Studio version 17.10.

Copy link
Contributor

@michelleangela : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@michelleangela
Copy link
Contributor Author

Adding @jorive to review.

Copy link
Contributor

Learn Build status updates of commit eda64bc:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/build/reference/arch-arm64.md ⚠️Warning Details
docs/build/reference/compiler-options-listed-alphabetically.md ✅Succeeded
docs/build/reference/compiler-options-listed-by-category.md ✅Succeeded
docs/build/reference/feature-arm64.md ✅Succeeded
docs/build/toc.yml ✅Succeeded

docs/build/reference/arch-arm64.md

  • Line 27, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to <blockquote>

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 08a8ec3:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/arch-arm64.md ✅Succeeded
docs/build/reference/compiler-options-listed-alphabetically.md ✅Succeeded
docs/build/reference/compiler-options-listed-by-category.md ✅Succeeded
docs/build/reference/feature-arm64.md ✅Succeeded
docs/build/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 53b271d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/arch-arm64.md ✅Succeeded
docs/build/reference/compiler-options-listed-alphabetically.md ✅Succeeded
docs/build/reference/compiler-options-listed-by-category.md ✅Succeeded
docs/build/reference/feature-arm64.md ✅Succeeded
docs/build/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link

@jorive jorive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jak-MS
Copy link
Contributor

Jak-MS commented May 15, 2024

@TylerMSFT

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label May 15, 2024
Copy link
Contributor

Learn Build status updates of commit 313e825:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/arch-arm64.md ✅Succeeded
docs/build/reference/compiler-options-listed-alphabetically.md ✅Succeeded
docs/build/reference/compiler-options-listed-by-category.md ✅Succeeded
docs/build/reference/feature-arm64.md ✅Succeeded
docs/build/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit acd3fdf:

✅ Validation status: passed

File Status Preview URL Details
docs/build/reference/arch-arm64.md ✅Succeeded
docs/build/reference/compiler-options-listed-alphabetically.md ✅Succeeded
docs/build/reference/compiler-options-listed-by-category.md ✅Succeeded
docs/build/reference/feature-arm64.md ✅Succeeded
docs/build/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@michelleangela
Copy link
Contributor Author

Closing this PR and created another one in other cpp-docs repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants