Skip to content

Add links for "Just My Code" and "Edit and Continue". #5056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

rockchenn
Copy link

No description provided.

Copy link
Contributor

@rockchenn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8f301c8:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/build/cmake-projects-in-visual-studio.md ⚠️Warning Details

docs/build/cmake-projects-in-visual-studio.md

  • Line 137, Column 258: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/visualstudio/debugger/just-my-code' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 141, Column 234: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-enable-and-disable-edit-and-continue' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 137, Column 258: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/visualstudio/debugger/just-my-code' will be broken in isolated environments. Replace with a relative link.
  • Line 141, Column 234: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-enable-and-disable-edit-and-continue' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Use repo links - preferred.
@TylerMSFT
Copy link
Collaborator

I fixed the links. We don't allow the locale (en-us) because it breaks localization for people who use another language.
We also prefer repo relative links.
Thank you for adding links here. They are a good addition.

Copy link
Contributor

Learn Build status updates of commit 1b92eac:

✅ Validation status: passed

File Status Preview URL Details
docs/build/cmake-projects-in-visual-studio.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt ShannonLeavitt merged commit 844d1b8 into MicrosoftDocs:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants