-
Notifications
You must be signed in to change notification settings - Fork 967
Improve code examples in writing-an-exception-filter.md #5081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeremy-rifkin : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 3704b28: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit bde53f9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not a fan of the old formatting or the new formatting. We changed our style for braces to be on their own lines as one example. But I think this is an improvement and particularly the change from ResetVars() to HandleOverflow() is better. Thank you.
#sign-off |
Thanks Tyler for the quick response and merge. Are there any code style guidelines written down for the microsoft docs? |
not that I'm aware of for the c++ docs. |
This PR is primarily a formatting PR. I recognize that style is highly subjective, however, I am opening this PR because I find the formatting in writing-an-exception-filter.md to be confusing and more importantly inconsistent.
This PR:
__except ( Eval_Exception( GetExceptionCode( )))
especially egregious formatting)The one substantive change I made is changing
ResetVars
to a more generalHandleOverflow
function, as I found the purpose ofResetVars
misleading in this example.In preparing this PR I consulted the style guide and in absense of clear code formatting guidelines I looked to other well-formatted articles, such as Modern C++ best practices for exceptions and error handling.