Skip to content

Fix malformed anchor in headers #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Rageking8
Copy link
Contributor

Fix problem where a malformed anchor causes a whole chunk of text to be rendered as a link.

See MicrosoftDocs/visualstudio-docs#10362 for an example of the malformed rendering.

The bulk of the regression was introduced in 45d31cd.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit ec32162:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64ec-windows-abi-conventions.md ✅Succeeded
docs/build/reference/contents-of-a-makefile.md ✅Succeeded
docs/build/reference/creating-a-makefile-project.md ✅Succeeded
docs/build/reference/defining-an-nmake-macro.md ✅Succeeded
docs/build/reference/inference-rules.md ✅Succeeded
docs/build/reference/inline-files-in-a-makefile.md ✅Succeeded
docs/build/reference/makefile-preprocessing.md ✅Succeeded
docs/build/reference/special-nmake-macros.md ✅Succeeded
docs/build/reference/using-an-nmake-macro.md ✅Succeeded
docs/cpp/if-else-statement-cpp.md ✅Succeeded
docs/cpp/main-function-command-line-args.md ✅Succeeded
docs/cppcx/platform-intptr-value-class.md ✅Succeeded
docs/mfc/reference/cmfcbutton-class.md ✅Succeeded
docs/mfc/reference/extension-dll-macros.md ✅Succeeded
docs/parallel/amp/reference/concurrency-direct3d-namespace-functions-amp.md ✅Succeeded
docs/parallel/amp/reference/concurrency-precise-math-namespace-functions.md ✅Succeeded
docs/parallel/amp/reference/norm-3-class.md ✅Succeeded
docs/parallel/amp/reference/tile-barrier-class.md ✅Succeeded
docs/parallel/concrt/reference/reader-writer-lock-class.md ✅Succeeded
docs/standard-library/scoped-allocator-adaptor-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@Court72
Copy link
Contributor

Court72 commented Aug 23, 2024

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Aug 23, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rageking8, the format that's in there seems to work fine. I have no objection to the long form so will merge this.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit 8d19ae9 into MicrosoftDocs:main Aug 23, 2024
2 checks passed
@Rageking8 Rageking8 deleted the fix-malformed-anchor-in-headers branch September 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants