improved description for C26435 #5118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation improvement motivated by https://developercommunity.visualstudio.com/t/Warning-C26435-contradicts-to-Compiler-E/10355159 When a `virtual` function declaration includes the `final` specifier, the warning message for C26435 incorrectly suggested specifying exactly one of the two. The correct solution is to specify zero of the two. The warning message has been updated in MSVC and this documentation change reflects that as well as provides an example of how to fix the incorrect pattern.
|
@carsonRadtke : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 8d66e00: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@TylerMSFT Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation improvement motivated by https://developercommunity.visualstudio.com/t/Warning-C26435-contradicts-to-Compiler-E/10355159
When a
virtualfunction declaration includes thefinalspecifier, the warning message for C26435 incorrectly suggested specifying exactly one of the two. The correct solution is to specify zero of the two. The warning message has been updated in MSVC and this documentation change reflects that as well as provides an example of how to fix the incorrect pattern.