Skip to content

Correct mismatched quotes #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Rageking8
Copy link
Contributor

Correct mismatched quotes with some metadata changes.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 3483734:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/option-avxencoding-masm.md ✅Succeeded
docs/atl-mfc-shared/reference/codesnippet/CPP/cfiledialog-class_3.cpp ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-error-c2394.md ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-fatal-errors-c999-through-c1999.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Unapproved file extension(s) This PR contains file types that are not supported in the repo. The only supported file types are jpg, gif, png, json, svg and md.

---
# Compiler Error C2394

'your_type::operator'op'" : CLR or WinRToperator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'your_type'
"type::operator 'operator'": CLR/WinRT operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'type'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referred to the following line to tidy up the error message above:

|[Compiler error C2394](compiler-error-c2394.md)|'*type*::operator *operator*': CLR/WinRT operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = '*type*'|

Copy link
Collaborator

@TylerMSFT TylerMSFT Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our style for these isn't consistent, sadly. I don't think I like the double quotes, though, since they don't appear in the actual error. I tweaked this to match what you refer to, as that seems closest to what the compiler generates. This is a verbatim of what I get when I compile the error sample at the command line: test.cpp(2): error C2394: 'Y::operator -': CLR operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'Y'

@v-dirichards
Copy link
Contributor

@TylerMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 20, 2025
Matched what's in the compiler-errors-c2300-through-c2399.md doc, which also matches what I get when I compile this error.
Copy link
Contributor

Learn Build status updates of commit 8fcae9a:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/option-avxencoding-masm.md ✅Succeeded
docs/atl-mfc-shared/reference/codesnippet/CPP/cfiledialog-class_3.cpp ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-error-c2394.md ✅Succeeded
docs/error-messages/compiler-errors-1/compiler-fatal-errors-c999-through-c1999.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Unapproved file extension(s) This PR contains file types that are not supported in the repo. The only supported file types are jpg, gif, png, json, svg and md.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your cleanup. I made a tweak to the C2394 error formatting.

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit 7605480 into MicrosoftDocs:main Feb 20, 2025
2 checks passed
@Rageking8 Rageking8 deleted the correct-mismatched-quotes branch February 21, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants