-
Notifications
You must be signed in to change notification settings - Fork 967
Correct mismatched quotes #5194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct mismatched quotes #5194
Conversation
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 3483734: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
--- | ||
# Compiler Error C2394 | ||
|
||
'your_type::operator'op'" : CLR or WinRToperator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'your_type' | ||
"type::operator 'operator'": CLR/WinRT operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'type' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referred to the following line to tidy up the error message above:
cpp-docs/docs/error-messages/compiler-errors-1/compiler-errors-c2300-through-c2399.md
Line 112 in 3479df2
|[Compiler error C2394](compiler-error-c2394.md)|'*type*::operator *operator*': CLR/WinRT operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = '*type*'| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our style for these isn't consistent, sadly. I don't think I like the double quotes, though, since they don't appear in the actual error. I tweaked this to match what you refer to, as that seems closest to what the compiler generates. This is a verbatim of what I get when I compile the error sample at the command line: test.cpp(2): error C2394: 'Y::operator -': CLR operator not valid. At least one parameter must be of the following types: 'T^', 'T^%', 'T^&', where T = 'Y'
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Matched what's in the compiler-errors-c2300-through-c2399.md doc, which also matches what I get when I compile this error.
Learn Build status updates of commit 8fcae9a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your cleanup. I made a tweak to the C2394 error formatting.
#sign-off |
Correct mismatched quotes with some metadata changes.