-
Notifications
You must be signed in to change notification settings - Fork 967
Tweaks for C6030 warning page #5203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks for C6030 warning page #5203
Conversation
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 423c0f3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Just noticed that inline code blocks in link text does not affect the rendered output. For example both of these lines would look the same: [__declspec(noreturn)](https://learn.microsoft.com/en-us/cpp/cpp/noreturn?view=msvc-170)
[`__declspec(noreturn)`](https://learn.microsoft.com/en-us/cpp/cpp/noreturn?view=msvc-170) However, on GitHub there is a visible difference: __declspec(noreturn) So should we prefer the former or latter? |
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
The latter (use backticks). The reason is that the backticks prevent automatic machine translation and we don't want translation to happen here. The automatic translator is often smart enough not to try, but rather than play whack-a-mole trying to outsmart it, I default to using the backticks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
#sign-off |
Summary:
[[noreturn]]
and__declspec(noreturn)
[[ noreturn ]]
and the function name (prefer snake case for uniformity)