Skip to content

Update error boilerplate include #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Feb 28, 2025

Summary:

  • Tweak the slightly awkward "make many subsequent errors go away"
  • Remove specifics on how the user lands on such a page (the F1 part)
  • Remove link to issues page of this repo (since it has been disabled some time ago)
  • Update Send a Suggestion button to Suggest a Feature (as found in the latest version of VS)
  • Update "Microsoft Q&A C++" link to prevent redirect, and prefer an absolute link for maximal compatibility (i.e. opening the old relative link on GitHub preview leads to a 404)

Copy link
Contributor

Learn Build status updates of commit e80b3f2:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/error-messages/includes/error-boilerplate.md ⚠️Warning Details

docs/error-messages/includes/error-boilerplate.md

  • Line 9, Column 63: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/answers/tags/314/cpp' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 9, Column 63: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/answers/tags/314/cpp' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit d1cd2c2:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/includes/error-boilerplate.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@ttorble
Copy link
Contributor

ttorble commented Feb 28, 2025

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 28, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes. Thank you!

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit e0eb502 into MicrosoftDocs:main Feb 28, 2025
2 checks passed
@Rageking8 Rageking8 deleted the update-error-boilerplate-include branch March 1, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants