Skip to content

Refresh "Inheritance (C++)" #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

Rageking8
Copy link
Contributor

Summary:

  • Format syntax code snippet and make the 2 classes have different names for clarity
  • Add bunch of links to other pages and backticks for terms, where appropriate
  • Add "Microsoft Specific" for the __super and __interface links at the bottom to make it explicit that those are non-standard (feel free to revert if undesirable)
  • Edit metadata, minor typo fix, simplify links, and remove extra spaces

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f50becb:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/inheritance-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@ttorble
Copy link
Contributor

ttorble commented Apr 1, 2025

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Apr 1, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the links and cleaning up the file paths.
The new class names are better.
Regarding Microsoft-specific, I think it's great to call that out.
Much thanks!

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit b5ef532 into MicrosoftDocs:main Apr 1, 2025
2 checks passed
@Rageking8 Rageking8 deleted the refresh-inheritance-cpp branch April 22, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants