Skip to content

Update how-to-convert-between-various-string-types.md #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2019

Conversation

drvoss
Copy link
Contributor

@drvoss drvoss commented Dec 29, 2018

fix typo

@PRMerger17
Copy link
Contributor

@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@GitHubber17
Copy link
Contributor

@corob-msft - Would you review the proposed changes? Thanks

@PRMerger16
Copy link
Contributor

@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@PRMerger17
Copy link
Contributor

@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@PRMerger18
Copy link
Contributor

@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drvoss I'm uncomfortable with code that uses both std::cout and std::wcout in the same function. That was addressed by commenting out the code on line 192. Unfortunately, it looks like this is done in other examples, so maybe the solution is a more general revisit of this content for coding style.

@colin-home colin-home closed this Mar 1, 2019
@colin-home colin-home reopened this Mar 1, 2019
@PRMerger14
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@colin-home colin-home merged commit bca423f into MicrosoftDocs:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants