-
Notifications
You must be signed in to change notification settings - Fork 967
Update how-to-convert-between-various-string-types.md #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
@corob-msft - Would you review the proposed changes? Thanks |
@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drvoss I'm uncomfortable with code that uses both std::cout and std::wcout in the same function. That was addressed by commenting out the code on line 192. Unfortunately, it looks like this is done in other examples, so maybe the solution is a more general revisit of this content for coding style.
@corob-msft : Thanks for your contribution! The author, @, has been notified to review your proposed change. |
fix typo