Clarifying remarks about pitch, yaw, and roll #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walbourn : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
stevewhims
approved these changes
Jan 11, 2022
|
@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectXMath uses pitch for x-axis, yaw for y-axis, and roll for z-axis which is pretty typical for games. That said, these labels are essentially arbitrary and other coordinate systems use those same labels for different axes.
Adds clarifications to the four functions that use roll, pitch, and yaw.