-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add info to change installer UI language #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The installer itself can have its UI language changed after the fact.
Hi @artl93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
||
## Changing the installer Language | ||
|
||
By default, the installer program tries to match the language of the operating system when run for the first time. The installer will remember this setting. The setting can later be chagned by running the installer from the command line. For example, the user can force the installer to run in Englishby running **vs_installer.exe --locale en-US"**. This setting will then be remembered when the installer is run the next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typos: "chagned" -> "changed", "Englishby" -> "English by"
Extra double quote in the command line example. You might consider using a in line code block vs_installer.exe --local en-US
using backticks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well, I'd like to word-craft this a bit:
By default, the installer program tries to match the language of the operating system when it is run for the first time. The installer will remember this setting. You can change the setting later by running the installer from the command line. For example, you can force the installer to run in English by running the vs_installer.exe --locale en-US" command. This setting will then be remembered when the installer is run the next time.
It's best to say "you" when you can, as a best practice.
@@ -93,6 +93,11 @@ To install Visual Studio 2017 RC in a language of your choosing, click the **Lan | |||
|
|||
> [!IMPORTANT] | |||
> While Visual Studio 2017 RC in general is supported for use in a production environment, those workloads and components that are marked "Preview" in the installation UI are not supported for use in a production environment. | |||
|
|||
## Changing the installer Language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to capitalize "Language" here. Can just be "Changing the installer language"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be a level 3 heading, as it is a child of the parent, "Install language packs"
Also, please change this to "Change the installer language," because it's a best practice to avoid gerunds (words ending in '-ing' whenever we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment: This section should not appear after the important "production environment" note. In fact, that note should be the last text on the page, directly before the See Also links. (We're hoping that people will see this note before they comment on specific things that we already know aren't working yet in this RC, as the note appears (or should appear) close to the "Post Comment" box.
I was still working on it... :-( |
As a suggestion, for .NET we have a label called WIP to indicate topics are not ready to be merged yet. |
Removed the 2019 moniker from the last image
Update landing page.
The installer itself can have its UI language changed after the fact.