Skip to content

Directory.Build.props and Directory.Build.targets work with C++ projects #10202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mletterle
Copy link
Contributor

Since Microsoft.Cpp.targets ultimately imports Microsoft.Common.targets and Microsoft.Cpp.Default.props ultimately imports Microsoft.Common.props the Directory.Build.targets and Directory.Build.props customization works as expected with .vcxproj VC++ projects. In fact it's a documented method to integrate vcpkg.

Copy link
Contributor

@mletterle : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mletterle
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @ghogen

Copy link
Contributor

Learn Build status updates of commit 27e3b0b:

✅ Validation status: passed

File Status Preview URL Details
docs/msbuild/customize-by-directory.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 17, 2024

@ghogen

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 17, 2024
@ghogen
Copy link
Collaborator

ghogen commented Apr 25, 2024

Thanks! I made a similar change to the same file, since I saw someone had reported this via the Customer Feedback channel.

@ghogen ghogen merged commit 48165f5 into MicrosoftDocs:main Apr 25, 2024
@mletterle mletterle deleted the vcxproj_dirprops branch April 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants