Fix project name in adding-a-tool-window.md #10478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saranshsaini : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
#sign-off |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @maiak |
|
Learn Build status updates of commit d67f05f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@maiak Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a typo, the first step says to call the project "FirstToolWin" but then throughout the project is referenced as FirstToolWindow. For example the second step under the "Add a toolbar to the tool window" section says find the node with name "guidFirstToolWindowPackageCmdSet" but that should be "guidFirstToolWindPackageCmdSet" if the project were called FirstToolWin, right?
Caused confusion for me as a first time VS extension developer so just wanted to clarify and fix this. Lmk if I am missing something.