Update example usage for IDiaSymbol::get_value #10493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that using `VariantInit` from oleauto.h is more future-proof rather than manually initializing the VARIANT's fields in case the internal implementation of VARIANT/VARIANTARG changes.
|
@Michael-K-Stein : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit d75523a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
Mikejo5000
approved these changes
Nov 15, 2024
|
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that using
VariantInitfrom oleauto.h is more future-proof rather than manually initializing the VARIANT's fields in case the internal implementation of VARIANT/VARIANTARG changes.Regarding the "see also" added at the end: I see that it refers to "previous versions" topic and there is a warning banner when entering the page. Not sure if it is better this way or if we should refer readers to VariantInit function (oleauto.h) directly. On the other hand, that page refers readers to Variant Manipulation Functions