Skip to content

Update 2017 firewall page to remove outdated reference to incredibuild CDN #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PoulChapman
Copy link
Contributor

…r.md

removed outdated reference to incredibuild CDN

…r.md

removed outdated reference to incredibuild CDN
Copy link
Contributor

@PoulChapman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PoulChapman
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @anandmeg

Copy link
Contributor

Learn Build status updates of commit 70820db:

✅ Validation status: passed

File Status Preview URL Details
docs/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 19, 2024

hi @PoulChapman - you can make this change in the private repo visualstudio-docs-pr and sign off on your own PR. And in the future (if you have access) you should use the private repos for updates. Here in the public repo, you'll need to wait for @anandmeg to review and approve.

@anandmeg
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 19, 2024
@anandmeg
Copy link
Collaborator

anandmeg commented Jan 3, 2025

@PoulChapman, did you mean to make this change for 2017?
This is the 2019/2022 page which is already addressed by your other PR: #10546.

The 2017 page is in the archive repo (visualstudio-docs-archive-pr): /visualstudio-docs-archive-pr/Docs/vs-2017/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md

@PoulChapman
Copy link
Contributor Author

@PoulChapman, did you mean to make this change for 2017? This is the 2019/2022 page which is already addressed by your other PR: #10546.

The 2017 page is in the archive repo (visualstudio-docs-archive-pr): /visualstudio-docs-archive-pr/Docs/vs-2017/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md

Oops... Yes. I've created a PR for the archive site here: https://github.com/MicrosoftDocs/visualstudio-docs-archive-pr/pull/104

@anandmeg
Copy link
Collaborator

anandmeg commented Jan 7, 2025

@PoulChapman, did you mean to make this change for 2017? This is the 2019/2022 page which is already addressed by your other PR: #10546.
The 2017 page is in the archive repo (visualstudio-docs-archive-pr): /visualstudio-docs-archive-pr/Docs/vs-2017/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md

Oops... Yes. I've created a PR for the archive site here: MicrosoftDocs/visualstudio-docs-archive-pr#104

Approved and merged the archive PR. I will close this one.

@anandmeg
Copy link
Collaborator

anandmeg commented Jan 7, 2025

Closing this PR as https://github.com/MicrosoftDocs/visualstudio-docs-archive-pr/pull/104 is created in the archive repo.

@anandmeg anandmeg closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants