Skip to content

Updated index.md #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jul 3, 2018
Merged

Updated index.md #1187

merged 2 commits into from Jul 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2018

  • Recast "for creating" and replaced with "to create" in Intro section.
  • Added a bullet list for .NET Core projects in the .Net Core section.
  • Fixed capitalization errors and removed extra spaces between words.

Recast "for creating" and replaced with "to create" in Intro section. 
Added a bullet list for .NET Core projects in the .Net Core section.
Fixed capitalization errors and removed extra spaces between words.
@msftclas
Copy link

msftclas commented Jun 29, 2018

CLA assistant check
All CLA requirements met.

@opbld37
Copy link

opbld37 commented Jun 29, 2018

✅ Validation status: passed

File Status Preview URL Details
mac/index.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@PRMerger19
Copy link
Contributor

@dsmatlak : Thanks for your contribution! The author, @asb3993, has been notified to review your proposed change.

mac/index.md Outdated
@@ -41,7 +41,12 @@ F# is a strongly-typed functional programming language designed to run on .NET.

## .NET Core

[.NET Core](https://www.microsoft.com/net/core#macos) is a platform for creating applications that run on Windows, Linux, and Mac. Visual Studio for Mac has support for loading, creating, running, and debugging .NET Core projects.
[.NET Core](https://www.microsoft.com/net/core#macos) is a platform to create applications that run on Windows, Linux, and Mac. Visual Studio for Mac has support for these .NET Core projects:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think putting this as a bulleted list makes sense. These are all actions that are supported, not types of projects.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I will remove the bullet list.

@timeyoutakeit
Copy link
Contributor

Hey @dsmatlak, this looks great and I appreciate the additions. There's just one issue that I think needs to be fixed before this can be merged.

Removed the bullet list from the .NET Core section.
@PRMerger14
Copy link
Contributor

@dsmatlak : Thanks for your contribution! The author, @asb3993, has been notified to review your proposed change.

@opbld36
Copy link

opbld36 commented Jul 3, 2018

✅ Validation status: passed

File Status Preview URL Details
mac/index.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@timeyoutakeit
Copy link
Contributor

Approved!

This will be merged shortly.

Thanks again.

@GitHubber17 GitHubber17 merged commit 1e947f7 into MicrosoftDocs:master Jul 3, 2018
@ghost ghost deleted the dsmatlak_docs branch July 7, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.