Skip to content

Add --locale parameter #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2016
Merged

Add --locale parameter #12

merged 3 commits into from
Nov 30, 2016

Conversation

artl93
Copy link
Contributor

@artl93 artl93 commented Nov 29, 2016

Added UI locale parameter documentation

Added UI locale parameter documentation
@msftclas
Copy link

Hi @artl93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Art Leonard). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@@ -59,7 +59,7 @@ When you install Visual Studio 2017 RC from a command prompt, you can use the fo
| ```--sharedInstallDir <dir>``` | Optional: The target installation directory for shared payloads. |
| ```--compatInstallDir <dir>``` | Optional: The target installation directory for legacy compatibility payloads. |
| ```--layoutDir <dir>```, ```--layoutDirectory <dir>``` | Optional: The layout directory in which to find packages.|

| ```--locale <language-locale>``` | Optional: Change the locale of the user interface for the installer. Setting will be preseved. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "Change the display language of the user interface for the installer. The setting will be preserved".
Note the typo "preserved" -> "preserved".
You might think say "persisted" instead of "preserved"

@@ -59,7 +59,7 @@ When you install Visual Studio 2017 RC from a command prompt, you can use the fo
| ```--sharedInstallDir <dir>``` | Optional: The target installation directory for shared payloads. |
| ```--compatInstallDir <dir>``` | Optional: The target installation directory for legacy compatibility payloads. |
| ```--layoutDir <dir>```, ```--layoutDirectory <dir>``` | Optional: The layout directory in which to find packages.|

| ```--locale <language-locale>``` | Optional: Change the locale of the user interface for the installer. Setting will be preseved. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "Change the display language of the user interface for the installer. The setting will be preserved".
Note the typo "preseved" -> "preserved".
You might think say "persisted" instead of "preserved"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you noticed the other change in the suggested sentence. Do you want to say "Change the locale..." or "Change the display language..."?
"display language" may be clearer to users.

Copy link
Contributor Author

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Changed to "display language"
@gregvanl gregvanl merged commit af24da1 into MicrosoftDocs:master Nov 30, 2016
fenxu pushed a commit that referenced this pull request Aug 7, 2017
fenxu pushed a commit that referenced this pull request Jul 19, 2018
fenxu pushed a commit that referenced this pull request Jul 25, 2018
ghogen pushed a commit that referenced this pull request May 3, 2021
learn-build-service-prod bot pushed a commit that referenced this pull request May 13, 2025
Updated with review from kkeirstead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants