-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add --locale parameter #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added UI locale parameter documentation
Hi @artl93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
@@ -59,7 +59,7 @@ When you install Visual Studio 2017 RC from a command prompt, you can use the fo | |||
| ```--sharedInstallDir <dir>``` | Optional: The target installation directory for shared payloads. | | |||
| ```--compatInstallDir <dir>``` | Optional: The target installation directory for legacy compatibility payloads. | | |||
| ```--layoutDir <dir>```, ```--layoutDirectory <dir>``` | Optional: The layout directory in which to find packages.| | |||
|
|||
| ```--locale <language-locale>``` | Optional: Change the locale of the user interface for the installer. Setting will be preseved. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "Change the display language of the user interface for the installer. The setting will be preserved".
Note the typo "preserved" -> "preserved".
You might think say "persisted" instead of "preserved"
@@ -59,7 +59,7 @@ When you install Visual Studio 2017 RC from a command prompt, you can use the fo | |||
| ```--sharedInstallDir <dir>``` | Optional: The target installation directory for shared payloads. | | |||
| ```--compatInstallDir <dir>``` | Optional: The target installation directory for legacy compatibility payloads. | | |||
| ```--layoutDir <dir>```, ```--layoutDirectory <dir>``` | Optional: The layout directory in which to find packages.| | |||
|
|||
| ```--locale <language-locale>``` | Optional: Change the locale of the user interface for the installer. Setting will be preseved. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "Change the display language of the user interface for the installer. The setting will be preserved".
Note the typo "preseved" -> "preserved".
You might think say "persisted" instead of "preserved"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you noticed the other change in the suggested sentence. Do you want to say "Change the locale..." or "Change the display language..."?
"display language" may be clearer to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Changed to "display language"
Updated with review from kkeirstead
Added UI locale parameter documentation