Skip to content

Kaller-updates #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2018
Merged

Kaller-updates #1750

merged 7 commits into from
Oct 29, 2018

Conversation

kallerdaller
Copy link
Contributor

Updated docs/ide/tutorial-csharp-console.md to be simpler
Updated docs/ide/visual-studio-ide.md to include details of the different versions

@msftclas
Copy link

msftclas commented Oct 26, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@TerryGLee TerryGLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallerdaller Thanks for contributing! We appreciate your input. However, I would like to request some changes to the PR as it relates to the console app tutorial, which I own. I've outlined that which should be changed--and why--in individual comments within the PR.

@@ -18,7 +18,7 @@ ms.workload:
---
# Tutorial: Get started with a C# console app in Visual Studio

In this tutorial for C#, you'll use Visual Studio to create and run a console app and explore some features of the [Visual Studio integrated development environment (IDE)](visual-studio-ide.md) while you do so.
In this tutorial for C#, you'll use Visual Studio to create and run a console app while exploring some features of the [Visual Studio integrated development environment (IDE)](visual-studio-ide.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallerdaller We purposefully avoid words ending in "-ing" because they translate oddly into some languages. Respectfully, I decline this edit.

@@ -38,7 +38,7 @@ First, we'll create a C# application project. The project type comes with all th

If you don't see the **Console App (.NET Core)** project template, you can get it by adding the **.NET Core cross-platform development** workload. You can add this workload in one of the two following ways, depending on which Visual Studio 2017 updates are installed on your machine.

#### Option 1: Use the New Project dialog box
#### Method 1: Use the New Project dialog box
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallerdaller We prefer to use "Option" as it is a term that we use uniformly throughout our content for situations such as this. Respectfully, I decline this edit.

@@ -132,7 +128,7 @@ If you don't see the **Console App (.NET Core)** project template, you can get i

![Code editor showing the C# Console Calculator](../ide/media/csharp-console-calculator-code.png)

1. Choose **Calculator** to run your program, or press **F5**.
1. Press **Calculator** or **F5** to run your program.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use "choose" in instances where someone would "click" something, and "press" where someone would physically press a key. (We use "choose" instead of "click" because some people might use a device with touch controls enabled.) Respectfully, I decline this edit.

@PRMerger14
Copy link
Contributor

@kallerdaller : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.

@kallerdaller
Copy link
Contributor Author

@TerryGLee I have rectified all of your comments and they all make sense. I apologize for any inconvenience caused.

@PRMerger6
Copy link
Contributor

@kallerdaller : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.

Copy link
Member

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallerdaller Thanks for your contribution!

@@ -18,7 +18,7 @@ ms.workload:

The Visual Studio *integrated development environment* is a creative launching pad that you can use to edit, debug, and build code, and then publish an app. An integrated development environment (IDE) is a feature-rich program that can be used for many aspects of software development. Over and above the standard editor and debugger that most IDEs provide, Visual Studio includes compilers, code completion tools, graphical designers, and many more features to ease the software development process.

Visual Studio is available for Windows and Mac. [Visual Studio for Mac](/visualstudio/mac/) has many of the same features as Visual Studio 2017, and is optimized for developing cross-platform and mobile apps.
Visual Studio is available for Windows and Mac. [Visual Studio for Mac](/visualstudio/mac/) has many of the same features as Visual Studio 2017, and is optimized for developing cross-platform and mobile apps. There are three editions types of Visual Studio 2017: **Community, Professional, Enterprise**. The **Community Edition** is free to download for the general public and students. Teams working professionally must buy the **Professional Edition**. Corperate enterprises have to buy the **Enterprise Edition**. Free trials are available for both **Professional** and **Enterprise**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Since the editions only apply to the Windows version, please move that discussion to a new paragraph.
  • Please don't boldface the list of editions.
  • The last three sentences are guidance that's best left to the VS marketing team. Instead, can you provide a link to https://visualstudio.microsoft.com/vs/compare/, a comparison of editions?

@PRMerger14
Copy link
Contributor

@kallerdaller : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.

@kallerdaller
Copy link
Contributor Author

@gewarren Would you rather this paragraph be placed somewhere else in the page? Should it have a subheading of its own?

@PRMerger9
Copy link
Contributor

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions

@PRMerger9 PRMerger9 closed this Oct 29, 2018
@gewarren gewarren reopened this Oct 29, 2018
Copy link
Member

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallerdaller Thanks, I like the addition of the editions information. I reworded it a bit according to our style guide.

@gewarren gewarren merged commit 8265bbb into MicrosoftDocs:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants