Skip to content

Update index.md #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Update index.md #1756

merged 2 commits into from
Oct 31, 2018

Conversation

Ishmeet-Singh-Saggu
Copy link
Contributor

A couple of minor changes

@PRMerger19
Copy link
Contributor

@Ishmeet-Singh-Saggu : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@gewarren
Copy link
Member

@Mikejo5000 Can you take a look at these suggestions?

Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ishmeet-Singh-Saggu The first edit is fine, but we need to stick to "Improve performance" for the second. "Optimize performance" is too formal based on current stylistic conventions.

@Mikejo5000
Copy link
Collaborator

@Ishmeet-Singh-Saggu "Measure performance" would be OK as an alternative.

@PRMerger14
Copy link
Contributor

@Ishmeet-Singh-Saggu : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@Ishmeet-Singh-Saggu
Copy link
Contributor Author

Thanks for suggestion. I have made the required changes as specified, please review it.

@Ishmeet-Singh-Saggu
Copy link
Contributor Author

Ishmeet-Singh-Saggu commented Oct 31, 2018 via email

@tfosmark
Copy link
Contributor

@Mikejo5000 Please review the changes and sign off if these are acceptable. Thank you!

Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks!

@Mikejo5000
Copy link
Collaborator

#sign-off

@PRMerger16
Copy link
Contributor

@Mikejo5000: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@Mikejo5000
Copy link
Collaborator

@gewarren for sign-off

@tfosmark tfosmark merged commit dfbe508 into MicrosoftDocs:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants