Add missing "Organize usings" .editorconfig setting for separating using groups #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in 15.5 [1]. [1] dotnet/roslyn#21087
|
|
|
@tiesmaster : Thanks for your contribution! The author, @kuhlenh, has been notified to review your proposed change. |
|
@gewarren - Would you review the proposed changes? Thanks. |
nschonni
reviewed
Feb 4, 2019
gewarren
reviewed
Feb 4, 2019
gewarren
reviewed
Feb 4, 2019
There was a problem hiding this comment.
@tiesmaster Thanks for adding this Thijs! Just one small request before we merge it.
|
@gewarren Thanks for the feedback, added. |
|
@gewarren Oh, I just saw it's the "example .editorconfig file with the default options", and this option is turned off by default, so I've changed the option to state |
gewarren
reviewed
Feb 5, 2019
also to the example EditorConfig file.
EditorConfig file to false, since that's the default for VS.
|
@gewarren I've fixed the issue. |
gewarren
approved these changes
Feb 5, 2019
|
Looks great! Thanks! |
gewarren
added a commit
that referenced
this pull request
Feb 6, 2019
Fix incorrect default value added in #2310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 15.5 "Separate using directive Groups" was added, but the
.editorconfigsetting (dotnet_separate_import_directive_groups) was missing. This PR adds that.