Skip to content

Fix syntax in C++ Core Guidelines MSBuild example #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chwarr
Copy link
Contributor

@chwarr chwarr commented Aug 18, 2017

There was an unclosed XML element in the BuildMacro example.

@msftclas
Copy link

@chwarr,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@chwarr chwarr force-pushed the cpp-core-buildmacro-syntax-fix branch from 91c623d to ce938ca Compare August 18, 2017 17:08
@chwarr chwarr changed the title Fix syntax in C++ Code Guidelines MSBuild example Fix syntax in C++ Core Guidelines MSBuild example Aug 18, 2017
@mikeblome
Copy link
Contributor

thanks!

@saldana
Copy link
Contributor

saldana commented Aug 18, 2017

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/using-the-cpp-core-guidelines-checkers.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@saldana
Copy link
Contributor

saldana commented Aug 18, 2017

✅ Validation status: passed

File Status Preview URL Details
docs/code-quality/using-the-cpp-core-guidelines-checkers.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@gregvanl gregvanl merged commit 4ba53e2 into MicrosoftDocs:master Aug 18, 2017
@chwarr chwarr deleted the cpp-core-buildmacro-syntax-fix branch August 18, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants