Skip to content

fix: MD019/no-multiple-space-atx #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 17, 2019

Multiple spaces after hash on atx style heading
Find: ^(#+) ( +)(.*)\n
Repalace:
Filter: $1 $3\n

@PRMerger20
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @Mikejo5000, has been notified to review your proposed change.

@nschonni nschonni force-pushed the fix--MD019/no-multiple-space-atx branch from a3fa094 to 2ffbbc4 Compare April 17, 2019 22:01
@PRMerger6
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @Mikejo5000, has been notified to review your proposed change.

@gewarren
Copy link
Member

It might be a good idea to explicitly look for <a after the multiple spaces and fix those in one commit. Then use your original regex to fix the remaining "extra spaces after hash" in a separate commit that would be easier to diff.

Multiple spaces after hash on atx style heading
Find: ^(#+) ( +)<
Repalace: $1 <
Filter: *.md
Multiple spaces after hash on atx style heading
Find: ^(#+) ( +)(.*)\n
Repalace:$1 $3\n
Filter: *.md
@nschonni nschonni force-pushed the fix--MD019/no-multiple-space-atx branch from 2ffbbc4 to a02d141 Compare April 17, 2019 22:13
@PRMerger9
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @Mikejo5000, has been notified to review your proposed change.

@nschonni
Copy link
Contributor Author

@gewarren I've split the two regexes into separate commits

@gewarren
Copy link
Member

@nschonni Thanks, looks good!

@gewarren gewarren merged commit d20565b into MicrosoftDocs:master Apr 17, 2019
@nschonni nschonni deleted the fix--MD019/no-multiple-space-atx branch April 17, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants