Skip to content

fix: MD003/heading-style/header-style #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nschonni
Copy link
Contributor

  • Suppress the H2 versions since I believe their is a TOC bug.
  • Escape trailing hashmark in title
  • Trim trailing/leading space
  • MD020 also overlaps the same lines

@PRMerger18
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @John-Hart, has been notified to review your proposed change.

@John-Hart
Copy link
Contributor

Most of this is outside the VSTO docs that I own. @gewarren could you help or help find the right people to review this?

Copy link
Member

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after one comment is addressed. Thanks!

- Suppress the H2 versions since I believe their is a TOC bug.
- Escape trailing hashmark in title
- Trim trailing/leading space
- MD020 also overlaps the same lines
@nschonni nschonni force-pushed the fix--MD003/heading-style/header-style2 branch from 3acecd3 to 90a1523 Compare April 18, 2019 17:10
@PRMerger8
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @John-Hart, has been notified to review your proposed change.

@gewarren gewarren merged commit 79caed1 into MicrosoftDocs:master Apr 18, 2019
@nschonni nschonni deleted the fix--MD003/heading-style/header-style2 branch April 18, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants