Skip to content

fix: MD005/list-indent #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

nschonni
Copy link
Contributor

Inconsistent indentation for list items at the same level

Inconsistent indentation for list items at the same level
@PRMerger19
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @evanwindom, has been notified to review your proposed change.

Consider starting bulleted lists at the beginning of the line
@PRMerger8
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @sayedihashimi, has been notified to review your proposed change.

@nschonni
Copy link
Contributor Author

Added in the "MD006/ul-start-left" since they're pretty related

@sayedihashimi
Copy link
Contributor

The changes for the docs that I authored (the 3 VSMac ones) looks good. There’s a lot of other edits to files that I don’t own. Not sure who should review/sign off on the PR.

@PRMerger18
Copy link
Contributor

@nschonni : Thanks for your contribution! The author, @sayedihashimi, has been notified to review your proposed change.

@nschonni
Copy link
Contributor Author

@sayedihashimi I think it is usually @gewarren that handles these cross area PRs

Copy link
Contributor

@evanwindom evanwindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to articles I authored are approved.


- The target resolution for Visual Studio is **1366x768**. This is the lowest resolution at which we promise a *good* user experience.
- The minimum resolution for Visual Studio Dev14 is **1280x720**. This means that it is *possible* to use Visual Studio at this resolution, although it might not be an optimal user experience. There is no guarantee that all aspects will be usable at resolutions lower than 1280x720.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The minimum resolution for Visual Studio Dev14 is **1280x720**. This means that it is *possible* to use Visual Studio at this resolution, although it might not be an optimal user experience. There is no guarantee that all aspects will be usable at resolutions lower than 1280x720.
- The minimum resolution for Visual Studio 2015 is **1280x720**. This means that it is *possible* to use Visual Studio at this resolution, although it might not be an optimal user experience. There is no guarantee that all aspects will be usable at resolutions lower than 1280x720.

@PRMerger9
Copy link
Contributor

@GitHubber17 : Thanks for your contribution! The author, @sayedihashimi, has been notified to review your proposed change.

@GitHubber17 GitHubber17 merged commit 08fabbd into MicrosoftDocs:master Apr 19, 2019
@nschonni nschonni deleted the fix--MD005/list-indent branch April 19, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants