Skip to content

Update C26432.md #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2019
Merged

Update C26432.md #3197

merged 1 commit into from
May 17, 2019

Conversation

lennartb-
Copy link
Contributor

Add hyperlinks to C++ Core Guidelines. Fixes #1772 and #1773. I hope it's okay to do this in one PR, since the changes are very similar. I slightly changed the sentence structure in C26409.md so the formatting matches.

Update C26409.md

Add links to Cpp Core Guidelines
@msftclas
Copy link

msftclas commented May 3, 2019

CLA assistant check
All CLA requirements met.

@PRMerger14
Copy link
Contributor

@lennartb- : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

@gewarren
Copy link
Member

@mikeblome Can you review this one?

Copy link
Contributor

@mikeblome mikeblome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lennartb- The URLs are returning 404 because they are mis-formatted. Before the # it should be .html, not /. Please fix those and verify they work. Otherwise looks great. Thanks!

@lennartb-
Copy link
Contributor Author

lennartb- commented May 17, 2019

@mikeblome Can you clarify? Both links to https://isocpp.github.io (e.g. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all) work for me (tested in Firefox, Edge and Chrome), and they also work for me from the markdown preview. Or do you mean the internal links (e.g. /cpp/standard-library/memory-functions#make_unique)? I'm not sure how I can test these, but I haven't changed them in the PR.

@Jak-MS
Copy link
Contributor

Jak-MS commented May 17, 2019

assuming by @mikeblome 's approval that this PR is ready for merge.

#sign-off

@PRMerger9
Copy link
Contributor

@Jak-MS: I'm sorry - only the author of this article, @mikeblome, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@Jak-MS Jak-MS merged commit 8f49658 into MicrosoftDocs:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperlink to R.11 please
7 participants