-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update C26432.md #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C26432.md #3197
Conversation
Update C26409.md Add links to Cpp Core Guidelines
@lennartb- : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change. |
@mikeblome Can you review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lennartb- The URLs are returning 404 because they are mis-formatted. Before the # it should be .html, not /. Please fix those and verify they work. Otherwise looks great. Thanks!
@mikeblome Can you clarify? Both links to https://isocpp.github.io (e.g. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all) work for me (tested in Firefox, Edge and Chrome), and they also work for me from the markdown preview. Or do you mean the internal links (e.g. |
assuming by @mikeblome 's approval that this PR is ready for merge. #sign-off |
@Jak-MS: I'm sorry - only the author of this article, @mikeblome, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias. |
Add hyperlinks to C++ Core Guidelines. Fixes #1772 and #1773. I hope it's okay to do this in one PR, since the changes are very similar. I slightly changed the sentence structure in C26409.md so the formatting matches.