-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add VB example to Xaml designer extensibility #3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Nukepayload2 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for contributing! :-)
@@ -80,6 +104,16 @@ if (type != null && buttonType != type.IsSubclassOf(buttonType)) | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind fixing the C# sample too? I'm pretty sure this was meant to say this:
if (type != null && type.IsSubclassOf(buttonType))
or shorter to match your change:
if (type?.IsSubclassOf(buttonType) == true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you change this line
AttributeTableBuilder builder = new AttributeTableBuilder();
with this one:
var builder = new AttributeTableBuilder();
Because C# Coding Conventions says:
Use implicit typing for local variables when the type of the variable is obvious from the right side of the assignment, or when the precise type is not important.
#sign-off |
Only Microsoft employees can sign off on PRs. Your PR will be routed for review. |
@lutzroeder - I'll merge this, but I can't verify that the links in line 44 are working correctly. Can you check them after the changes are live? Thanks. |
Issue: #3602
Before creating your pull request, please check your content against these quality criteria:
For more information about creating content for docs.microsoft.com, see the contributor guide at https://docs.microsoft.com/contribute/.