Skip to content

Add VB example to Xaml designer extensibility #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

Nukepayload2
Copy link
Contributor

Issue: #3602

Before creating your pull request, please check your content against these quality criteria:

  • Did you consider search engine optimization (SEO) when you chose the title in the metadata section and the H1 heading (i.e. the displayed title that starts with a single #)?
  • For new articles, did you add it to the table of contents?
  • Did you update the "ms.date" metadata for new or significantly updated articles?
  • Are technical terms and concepts introduced and explained, and are acronyms spelled out on first mention?
  • Should this page be linked to from other pages or Microsoft web sites?

For more information about creating content for docs.microsoft.com, see the contributor guide at https://docs.microsoft.com/contribute/.

@PRMerger15
Copy link
Contributor

@Nukepayload2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@mgoertz-msft mgoertz-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for contributing! :-)

@@ -80,6 +104,16 @@ if (type != null && buttonType != type.IsSubclassOf(buttonType))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing the C# sample too? I'm pretty sure this was meant to say this:
if (type != null && type.IsSubclassOf(buttonType)) or shorter to match your change:
if (type?.IsSubclassOf(buttonType) == true)

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Jul 9, 2019
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you change this line
AttributeTableBuilder builder = new AttributeTableBuilder();
with this one:
var builder = new AttributeTableBuilder();

Because C# Coding Conventions says:

Use implicit typing for local variables when the type of the variable is obvious from the right side of the assignment, or when the precise type is not important.

@lutzroeder
Copy link
Member

#sign-off

@PRMerger10
Copy link
Contributor

Only Microsoft employees can sign off on PRs. Your PR will be routed for review.

@Jak-MS
Copy link
Contributor

Jak-MS commented Jul 9, 2019

@lutzroeder - I'll merge this, but I can't verify that the links in line 44 are working correctly. Can you check them after the changes are live? Thanks.

@Jak-MS Jak-MS merged commit e6fb415 into MicrosoftDocs:master Jul 9, 2019
@Nukepayload2 Nukepayload2 deleted the patch-1 branch July 10, 2019 00:59
@lutzroeder lutzroeder removed their assignment Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants