Skip to content

Update walkthrough-creating-and-running-unit-tests-for-windows-store-… #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scout208
Copy link
Contributor

@scout208 scout208 commented Sep 10, 2019

Updated to reflect VS2019.

Just updated a couple of names that have been changed in the VS2019 wizard. Someone should update the screenshots with the latest version. I don't know how the old ones were created to add the annotations so I didn't do it myself.

@PRMerger13
Copy link
Contributor

@scout208 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik jborsecnik added the aq-pr-triaged tracking label for the PR review team label Sep 10, 2019
@gewarren
Copy link
Member

@scout208 Is this change only applicable to VS 2019? If so, we'll need to add separate instructions for those two steps for VS 2017 and 2019 since the file applies to both. We can do that using moniker tags, e.g.:

::: moniker range="vs-2017"
instructions...
::: moniker-end
::: moniker range=">=vs-2019"
instructions...
::: moniker-end

@scout208
Copy link
Contributor Author

@gewarren I'm not sure yet. I haven't tried it in VS2017 but I will take a look and update it accordingly.

@gewarren
Copy link
Member

@scout208 Thanks for pointing out that these instructions weren't applicable to VS 2019. Since we share this page for VS 2017 too, I've added instructions for both versions in a PR in our private repo. I'm going to close this PR in favor of that one.

@gewarren gewarren closed this Sep 25, 2019
@scout208 scout208 deleted the patch-1 branch September 28, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged tracking label for the PR review team change sent to author do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants