Fix git push error for protected CLA branch

docs/code-quality/ca1026-default-parameters-should-not-be-used.md

@@ -27,6 +27,9 @@ ms.workload:
 ## Cause
 An externally visible type contains an externally visible method that uses a default parameter.
 
+> [!NOTE]
+> This legacy rule is not available in FxCop Analyzers. For more information, see [Deprecated rules](fxcop-rule-port-status.md#deprecated-rules).
+
 ## Rule description
 Methods that use default parameters are allowed under the Common Language Specification (CLS); however, the CLS allows compilers to ignore the values that are assigned to these parameters. Code that is written for compilers that ignore default parameter values must explicitly provide arguments for each default parameter. To maintain the behavior that you want across programming languages, methods that use default parameters should be replaced with method overloads that provide the default parameters.
 

docs/code-quality/ca3075.md

@@ -107,7 +107,7 @@ class TestClass
         {
             var src = "";
             TextReader tr = new StreamReader(src);
-            XmlTextReader reader = new XmlTextReader(tr) { DtdProcessing = DtdProcessing.Prohibit };
+            XmlReader reader = XmlReader.Create(tr, new XmlReaderSettings() { XmlResolver = null });
             XmlSchema schema = XmlSchema.Read(reader , null);
             return schema;
         }
@@ -362,3 +362,6 @@ namespace TestNamespace
     }
 }
 ```
+
+> [!NOTE]
+> Although <xref:System.Xml.XmlReader.Create%2A?displayProperty=nameWithType> is the recommended way to create an <xref:System.Xml.XmlReader> instance, there are behavior differences from <xref:System.Xml.XmlTextReader>. An <xref:System.Xml.XmlReader> from <xref:System.Xml.XmlReader.Create%2A> normalizes `\r\n` to `\n` in XML values, while <xref:System.Xml.XmlTextReader> preserves the `\r\n` sequence.

docs/containers/container-tools-react.md

@@ -1,9 +1,9 @@
 ---
-title: Visual Studio Container Tools with ASP.NET Core
+title: Visual Studio Container Tools with ASP.NET Core and React.js
 author: ghogen
 description: Learn how to use Visual Studio Container Tools and Docker for Windows
 ms.author: ghogen
-ms.date: 06/06/2019
+ms.date: 10/16/2019
 ms.technology: vs-azure
 ms.topic: quickstart
 ---
@@ -17,12 +17,16 @@ With Visual Studio, you can easily build, debug, and run containerized ASP.NET C
 * [Docker Desktop](https://hub.docker.com/editions/community/docker-ce-desktop-windows)
 * [Visual Studio 2017](https://visualstudio.microsoft.com/vs/older-downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=vs+2017+download) with the **Web Development**, **Azure Tools** workload, and/or **.NET Core cross-platform development** workload installed
 * To publish to Azure Container Registry, an Azure subscription. [Sign up for a free trial](https://azure.microsoft.com/offers/ms-azr-0044p/).
+* [Node.js](https://nodejs.org/en/download/)
+* For Windows containers, Windows 10 version 1903 or later, to use the Docker images referenced in this article.
 ::: moniker-end
 ::: moniker range=">=vs-2019"
 * [Docker Desktop](https://hub.docker.com/editions/community/docker-ce-desktop-windows)
 * [Visual Studio 2019](https://visualstudio.microsoft.com/downloads) with the **Web Development**, **Azure Tools** workload, and/or **.NET Core cross-platform development** workload installed
 * [.NET Core 2.2 Development Tools](https://dotnet.microsoft.com/download/dotnet-core/2.2) for development with .NET Core 2.2
 * To publish to Azure Container Registry, an Azure subscription. [Sign up for a free trial](https://azure.microsoft.com/offers/ms-azr-0044p/).
+* [Node.js](https://nodejs.org/en/download/)
+* For Windows containers, Windows 10 version 1903 or later, to use the Docker images referenced in this article.
 ::: moniker-end
 
 ## Installation and setup
@@ -41,7 +45,7 @@ For Docker installation, first review the information at [Docker Desktop for Win
 
    ![Add Docker support](media/container-tools-react/vs2017/add-docker-support.png)
 
-1. Select the Linux container type, and click **OK**.
+1. Select the container type, and click **OK**.
 ::: moniker-end
 ::: moniker range=">=vs-2019"
 1. Create a new project using the **ASP.NET Core Web Application** template.
@@ -53,10 +57,12 @@ For Docker installation, first review the information at [Docker Desktop for Win
 
    ![Add Docker support](media/container-tools-react/vs2017/add-docker-support.png)
 
-1. Select Linux as the container type.
+1. Select the container type.
 ::: moniker-end
 
-## Dockerfile overview
+The next step is different depending on whether you're using Linux containers or Windows containers.
+
+## Modify the Dockerfile (Linux containers)
 
 A *Dockerfile*, the recipe for creating a final Docker image, is created in the project. Refer to [Dockerfile reference](https://docs.docker.com/engine/reference/builder/) for an understanding of the commands within it.
 
@@ -98,9 +104,74 @@ The preceding *Dockerfile* is based on the [microsoft/aspnetcore](https://hub.do
 
 When the new project dialog's **Configure for HTTPS** check box is checked, the *Dockerfile* exposes two ports. One port is used for HTTP traffic; the other port is used for HTTPS. If the check box isn't checked, a single port (80) is exposed for HTTP traffic.
 
+## Modify the Dockerfile (Windows containers)
+
+Open the project file by double-clicking on the project node, and update the project file (*.csproj) by adding the following property as a child of the `<PropertyGroup>` element:
+
+   ```xml
+    <DockerfileFastModeStage>base</DockerfileFastModeStage>
+   ```
+
+Update the Dockerfile by adding the following lines. This will copy node and npm to the container.
+
+   1. Add ``# escape=` `` to the first line of the Dockerfile
+   1. Add the following lines before `FROM … base`
+
+      ```
+      FROM mcr.microsoft.com/powershell:nanoserver-1903 AS downloadnodejs
+      SHELL ["pwsh", "-Command", "$ErrorActionPreference = 'Stop';$ProgressPreference='silentlyContinue';"]
+      RUN Invoke-WebRequest -OutFile nodejs.zip -UseBasicParsing "https://nodejs.org/dist/v10.16.3/node-v10.16.3-win-x64.zip"; `
+      Expand-Archive nodejs.zip -DestinationPath C:\; `
+      Rename-Item "C:\node-v10.16.3-win-x64" c:\nodejs
+      ```
+
+   1. Add the following line before and after `FROM … build`
+
+      ```
+      COPY --from=downloadnodejs C:\nodejs\ C:\Windows\system32\
+      ```
+
+   1. The complete Dockerfile should now look something like this:
+
+      ```
+      # escape=`
+      #Depending on the operating system of the host machines(s) that will build or run the containers, the image specified in the FROM statement may need to be changed.
+      #For more information, please see https://aka.ms/containercompat
+      FROM mcr.microsoft.com/powershell:nanoserver-1903 AS downloadnodejs
+      SHELL ["pwsh", "-Command", "$ErrorActionPreference = 'Stop';$ProgressPreference='silentlyContinue';"]
+      RUN Invoke-WebRequest -OutFile nodejs.zip -UseBasicParsing "https://nodejs.org/dist/v10.16.3/node-v10.16.3-win-x64.zip"; `
+      RUN Expand-Archive nodejs.zip -DestinationPath C:\; `
+      RUN Rename-Item "C:\node-v10.16.3-win-x64" c:\nodejs
+
+      FROM mcr.microsoft.com/dotnet/core/aspnet:2.2-nanoserver-1903 AS base
+      WORKDIR /app
+      EXPOSE 80
+      EXPOSE 443
+      COPY --from=downloadnodejs C:\nodejs\ C:\Windows\system32\
+
+      FROM mcr.microsoft.com/dotnet/core/sdk:2.2-nanoserver-1903 AS build
+      COPY --from=downloadnodejs C:\nodejs\ C:\Windows\system32\
+      WORKDIR /src
+      COPY ["WebApplication7/WebApplication37.csproj", "WebApplication37/"]
+      RUN dotnet restore "WebApplication7/WebApplication7.csproj"
+      COPY . .
+      WORKDIR "/src/WebApplication37"
+      RUN dotnet build "WebApplication37.csproj" -c Release -o /app/build
+
+      FROM build AS publish
+      RUN dotnet publish "WebApplication37.csproj" -c Release -o /app/publish
+
+      FROM base AS final
+      WORKDIR /app
+      COPY --from=publish /app/publish .
+      ENTRYPOINT ["dotnet", "WebApplication37.dll"]
+      ```
+
+1. Update the .dockerignore file by removing the `**/bin`.
+
 ## Debug
 
-Select **Docker** from the debug drop-down in the toolbar, and start debugging the app. You might see a message with a prompt about trusting a certificate; choose to trust the certificate to continue.
+Select **Docker** from the debug drop-down in the toolbar, and start debugging the app. You might see a message with a prompt about trusting a certificate; choose to trust the certificate to continue.  The first time you build, docker downloads the base images, so it might take a bit longer.
 
 The **Container Tools** option in the **Output** window shows what actions are taking place. You should see the installation steps associated with *npm.exe*.
 

docs/debugger/using-tracepoints.md

@@ -98,7 +98,7 @@ The behavior of the  **When changed**  option is different for different program
 - For native code, the debugger doesn't consider the first evaluation of the condition to be a change, so doesn't hit the tracepoint on the first evaluation.
 - For managed code, the debugger hits the tracepoint on the first evaluation after **When changed**  is selected.
 
-For a more comprehensive look at valid expressions you can use while setting conditions, see [Expressions in the debugger](expressions-in-the-debugger.md)
+For a more comprehensive look at valid expressions you can use while setting conditions, see [Expressions in the debugger](expressions-in-the-debugger.md).
 
 ### Hit count
 A hit count condition allows you to send output only after the line of code where the tracepoint is set has executed a specified number of times.
@@ -130,10 +130,13 @@ Sometimes when you inspect a property or attribute of an object, its value can c
 
 The way that expressions are evaluated in the **Action** message box may be different than the language you are currently using for development. For example, to output a string you do not need to wrap a message in quotes even if you normally would while using `Debug.WriteLine()` or `console.log()`. Also, the curly brace syntax (`{ }`) to output expressions may also be different than the convention for outputting values in your development language. (However, the contents within the curly braces (`{ }`) should still be written using your development language’s syntax).
 
+If you are trying to debug a live application and looking for a similar feature, check out our logpoint feature in the Snapshot Debugger. The snapshot debugger is a tool used to investigate issues in production applications. Logpoints also allow you to send messages to the Output Window without having to modify source code and do not impact your running application. For more information, see [Debug live Azure application](../debugger/debug-live-azure-applications.md).
+
 ## See also
 
 - [What is debugging?](../debugger/what-is-debugging.md)
 - [Write better C# code using Visual Studio](../debugger/write-better-code-with-visual-studio.md)
 - [First look at debugging](../debugger/debugger-feature-tour.md)
 - [Expressions in the debugger](expressions-in-the-debugger.md)
 - [Use breakpoints](../debugger/using-breakpoints.md)
+- [Debug live Azure applications](../debugger/debug-live-azure-applications.md)

docs/ide/index-writing-code.yml

@@ -50,6 +50,8 @@ landingContent:
             url: code-styles-and-code-cleanup.md
           - text: Code analysis
             url: ../code-quality/roslyn-analyzers-overview.md
+          - text: IntelliCode
+            url: /visualstudio/intellicode/intellicode-visual-studio
 
   # Card
   - title: Get started with programming languages
@@ -65,4 +67,4 @@ landingContent:
           - text: Create a console app with Visual Basic
             url: quickstart-visual-basic-console.md
           - text: Create a web app with Node.js
-            url: quickstart-nodejs.md
+            url: quickstart-nodejs.md

docs/ide/quickstart-aspnet-core.md

@@ -2,7 +2,7 @@
 title: "Create an ASP.NET Core web app in C#"
 description: "Learn how to create a simple Hello World web app in Visual Studio with C# and ASP.NET Core, step-by-step."
 ms.custom: "mvc,seodec18"
-ms.date: 06/06/2019
+ms.date: 10/15/2019
 ms.technology: vs-ide-general
 ms.prod: visual-studio-windows
 ms.topic: quickstart
@@ -104,9 +104,9 @@ Soon after, Visual Studio opens your project file.
 
    ![in the 'Configure your new project' window, name your project 'HelloWorld'](../get-started/csharp/media/vs-2019/csharp-name-your-aspnet-helloworld-project.png)
 
-1. In the **Create a new ASP.NET Core Web Application** window, verify that **ASP.NET Core 2.1** appears in the top drop-down menu. Then, choose **Web Application**, which includes example Razor Pages. Next, choose  **Create**.
+1. In the **Create a new ASP.NET Core Web Application** window, verify that **ASP.NET Core 3.0** appears in the top drop-down menu. Then, choose **Web Application**, which includes example Razor Pages. Next, choose  **Create**.
 
-   ![The 'Create a new ASP.NET Core Web Application' window](../get-started/csharp/media/vs-2019/csharp-create-aspnet-core-razor-pages-app.png)
+   ![The 'Create a new ASP.NET Core Web Application' window](../get-started/csharp/media/vs-2019/csharp-create-aspnet-razor-pages-app.png)
 
    Visual Studio opens your new project.
 

docs/ide/step-1-create-a-project-and-add-a-table-to-your-form.md

@@ -1,6 +1,6 @@
 ---
 title: "Step 1: Create a project and add a table to your form"
-ms.date: 05/31/2019
+ms.date: 10/15/2019
 ms.topic: tutorial
 ms.prod: visual-studio-windows
 ms.technology: vs-ide-general
@@ -38,11 +38,11 @@ The first step in creating a matching game is to create the project and add a ta
 
    ![View the 'Create a new project' window](../get-started/media/vs-2019/create-new-project-dark-theme.png)
 
-1. On the **Create a new project** window, enter or type *Windows Forms* in the search box.
+1. On the **Create a new project** window, enter or type *Windows Forms* in the search box. Next, choose **Desktop** from the **Project type** list.
 
-1. Choose the **Windows Forms App (.NET Framework)** template, and then choose **Next**.
+   After you apply the **Project type** filter, choose the **Windows Forms App (.NET Framework)** template for either C# or Visual Basic, and then choose **Next**.
 
-   ![Choose the Visual Basic template for the Windows Forms App (.NET Framework)](../get-started/visual-basic/media/vs-2019/vb-create-new-project-search-winforms-filtered.png)
+   ![Choose the either the C# or Visual Basic template for the Windows Forms App (.NET Framework)](./media/create-new-project-search-winforms-filtered.png)
 
    > [!NOTE]
    > If you do not see the **Windows Forms App (.NET Framework)** template, you can install it from the **Create a new project** window. In the **Not finding what you're looking for?** message, choose the **Install more tools and features** link.

docs/ide/step-1-create-a-project-and-add-labels-to-your-form.md

@@ -1,6 +1,6 @@
 ---
 title: "Step 1: Create a project and add labels to your form"
-ms.date: 05/31/2019
+ms.date: 10/15/2019
 ms.topic: tutorial
 ms.prod: visual-studio-windows
 ms.technology: vs-ide-general
@@ -43,11 +43,11 @@ As the first steps in developing this quiz, you create the project, and you add
 
    ![View the 'Create a new project' window](../get-started/media/vs-2019/create-new-project-dark-theme.png)
 
-1. On the **Create a new project** window, enter or type *Windows Forms* in the search box.
+1. On the **Create a new project** window, enter or type *Windows Forms* in the search box. Next, choose **Desktop** from the **Project type** list.
 
-1. Choose the **Windows Forms App (.NET Framework)** template, and then choose **Next**.
+   After you apply the **Project type** filter, choose the **Windows Forms App (.NET Framework)** template for either C# or Visual Basic, and then choose **Next**.
 
-   ![Choose the Visual Basic template for the Windows Forms App (.NET Framework)](../get-started/visual-basic/media/vs-2019/vb-create-new-project-search-winforms-filtered.png)
+   ![Choose the either the C# or Visual Basic template for the Windows Forms App (.NET Framework)](./media/create-new-project-search-winforms-filtered.png)
 
    > [!NOTE]
    > If you do not see the **Windows Forms App (.NET Framework)** template, you can install it from the **Create a new project** window. In the **Not finding what you're looking for?** message, choose the **Install more tools and features** link.

docs/ide/step-1-create-a-windows-forms-application-project.md

@@ -44,7 +44,7 @@ When you create a picture viewer, the first step is to create a Windows Forms Ap
 
    After you apply the **Project type** filter, choose the **Windows Forms App (.NET Framework)** template for either C# or Visual Basic, and then choose **Next**.
 
-   ![Choose the C# template for the Windows Forms App (.NET Framework)](./media/create-new-project-search-winforms-filtered.png)
+   ![Choose the either the C# or Visual Basic template for the Windows Forms App (.NET Framework)](./media/create-new-project-search-winforms-filtered.png)
 
    > [!NOTE]
    > If you don't see the **Windows Forms App (.NET Framework)** template, you can install it from the **Create a new project** window. In the **Not finding what you're looking for?** message, choose the **Install more tools and features** link.

docs/ide/step-2-add-a-random-object-and-a-list-of-icons.md

@@ -15,11 +15,12 @@ ms.workload:
   - "multiple"
 ---
 # Step 2: Add a Random object and a list of icons
+
 In this step, you create a set of matching symbols for the game. Each symbol is added to two random cells in the TableLayoutPanel on the form. To do this, you use two `new` statements to create two objects. The first is a <xref:System.Random> object, like the one you used in the math quiz game. It is used in this code to randomly choose cells in the TableLayoutPanel. The second object, which may be new to you, is a <xref:System.Collections.Generic.List%601> object which is used to store the randomly-chosen symbols.
 
 ## To add a random object and a list of icons
 
-1. In **Solution Explorer**, choose *Form1.cs* if you're using Visual C#, or *Form1.vb* if you're using Visual Basic, and then on the menu bar, choose **View** > **Code**. As an alternative, you can choose the **F7** key or double-click **Form1** in **Solution Explorer**.
+1. In **Solution Explorer**, choose *Form1.cs* if you're using C#, or *Form1.vb* if you're using Visual Basic, and then on the menu bar, choose **View** > **Code**. As an alternative, you can choose the **F7** key or double-click **Form1** in **Solution Explorer**.
 
      This displays the code module behind Form1.
 
@@ -35,8 +36,7 @@ In this step, you create a set of matching symbols for the game. Each symbol is
 
 3. When adding the List object, notice the **IntelliSense** window that opens. The following is a Visual C# example, but similar text appears when you add a list in Visual Basic.
 
-     ![Properties window showing Click event](../ide/media/express_listintellisense.png)
-IntelliSense window
+     ![Properties window showing Click event](../ide/media/express_listintellisense.png)<br/>***IntelliSense** window*
 
     > [!NOTE]
     > The IntelliSense window appears only when you enter code manually. If you copy and paste the code, it doesn't appear.
@@ -54,6 +54,6 @@ IntelliSense window
 
 ## To continue or review
 
-- To go to the next tutorial step, see [Step 3: Assign a random icon to each label](../ide/step-3-assign-a-random-icon-to-each-label.md).
+- To go to the next tutorial step, see [**Step 3: Assign a random icon to each label**](../ide/step-3-assign-a-random-icon-to-each-label.md).
 
 - To return to the previous tutorial step, see [Step 1: Create a project and add a table to your form](../ide/step-1-create-a-project-and-add-a-table-to-your-form.md).