Skip to content

Fix sample code #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix sample code #4385

merged 1 commit into from
Dec 2, 2019
+8 −8

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Nov 23, 2019

Fixes #3508

@PRMerger6
Copy link
Contributor

@NextTurn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6 PRMerger6 requested a review from Mikejo5000 November 23, 2019 16:01
@ShannonLeavitt ShannonLeavitt added the aq-pr-triaged tracking label for the PR review team label Nov 25, 2019
@Mikejo5000
Copy link
Collaborator

@rainersigwald Rainer, can you comment on this change? Thanks.

rainersigwald
rainersigwald approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NextTurn!

@Mikejo5000
Copy link
Collaborator

#sign-off

@ktoliver ktoliver merged commit 1ccd890 into MicrosoftDocs:master Dec 2, 2019
@nxtn nxtn deleted the xml branch December 2, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@Mikejo5000 Mikejo5000 Awaiting requested review from Mikejo5000

Assignees

@Mikejo5000 Mikejo5000

Labels
aq-pr-triaged tracking label for the PR review team change sent to author ready-to-merge visual-studio-windows/prod vs-javascript/tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad example
7 participants
@nxtn @PRMerger6 @Mikejo5000 @rainersigwald @ktoliver @PRMerger20 @ShannonLeavitt