Skip to content

Add IntermediateOutputPath #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2019
Merged

Add IntermediateOutputPath #4417

merged 3 commits into from
Dec 17, 2019

Conversation

Cosifne
Copy link
Contributor

@Cosifne Cosifne commented Dec 3, 2019 •
edited
Loading

Add the explaination for IntermediateOutputPath overriding for Live Unit Testing.
It is related to the PR

@PRMerger6 PRMerger6 requested a review from jillre December 3, 2019 02:02
@PRMerger6
Copy link
Contributor

@Cosifne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Cosifne
Copy link
Contributor Author

Cosifne commented Dec 3, 2019

Also tag @shyamnamboodiripad and @drognanar FYI

@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Dec 3, 2019
@PRMerger9
Copy link
Contributor

@Cosifne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Cosifne
Copy link
Contributor Author

Cosifne commented Dec 10, 2019 •
edited
Loading

@shyamnamboodiripad
So after discussing with Artur it looks like the FAQ page is quite old so we want to update all the related content in this PR.
I have already updated the content from Arthur and me. Please feel free to push content to this PR if you also need to update the FAQ pages.

Somehow I can't tag John here, I will notice him via other channel

@Cosifne Cosifne force-pushed the dev/shech/AddIntermediateOutputPath branch from 017758b to 2a6d628 Compare December 10, 2019 01:21
@PRMerger10
Copy link
Contributor

@Cosifne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TerryGLee TerryGLee assigned Mikejo5000 and unassigned jillre Dec 10, 2019
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 reviewed Dec 10, 2019
View reviewed changes
Mikejo5000
Mikejo5000 requested changes Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few GitHub suggestions

@Mikejo5000
Copy link
Collaborator

@Cosifne Shen, could you commit the suggestions above? Thanks.

@PRMerger19
Copy link
Contributor

@Cosifne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Cosifne Cosifne force-pushed the dev/shech/AddIntermediateOutputPath branch from 6098956 to a98e4dc Compare December 17, 2019 20:18
@PRMerger10
Copy link
Contributor

@Cosifne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Cosifne
Copy link
Contributor Author

Cosifne commented Dec 17, 2019

@Cosifne Shen, could you commit the suggestions above? Thanks.

Sorry being late, I have committed your suggestions. Thanks Mike

@Mikejo5000
Copy link
Collaborator

#sign-off

@PRMerger15
Copy link
Contributor

@Mikejo5000: I'm sorry - only the author of this article, @jillre, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@jborsecnik jborsecnik merged commit 01eca41 into MicrosoftDocs:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikejo5000 Mikejo5000 Mikejo5000 approved these changes

@jillre jillre Awaiting requested review from jillre

Assignees

@jillre jillre

@Mikejo5000 Mikejo5000

Labels
aq-pr-triaged tracking label for the PR review team change sent to author do-not-merge visual-studio-windows/prod vs-javascript/tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Cosifne @PRMerger6 @PRMerger9 @PRMerger10 @Mikejo5000 @PRMerger19 @PRMerger15 @jillre @jborsecnik @Jak-MS