Skip to content

enable syntax highlighting in C/C++ examples #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 140 commits into from
Dec 5, 2019

Conversation

Rastaban
Copy link
Contributor

@Rastaban Rastaban commented Dec 3, 2019

Enable syntax highlighting by adding cpp where it was missing from the markdown code block. I also cleaned up some of the whitespace and comments where lines didn't line up right or felt a little off.

I also added a C++17 example fix to one of the docs.

@jborsecnik
Copy link
Contributor

@mikeblome, does this need to go to the private repo?

@Rastaban, Microsoft authors and contributors are asked to make content contributions through the private repository so the content can be staged and validated by the current validation rules. For more information, see Should I work in a private or a public repo?

If you need help getting set up to work in the private repo, see Fork and clone a reposistory.

Also, you should link your Microsoft and GitHub aliases. See Set up Git repository locally for documentation to link your GitHub alias with your Microsoft account.

@jborsecnik jborsecnik added the aq-pr-triaged tracking label for the PR review team label Dec 3, 2019
@mikeblome
Copy link
Contributor

Phil is not a regular contributor or core PM, so I think we can merge this PR in the public repo base on this rule : "Microsoft employees from other teams can work in public repos at this time to ensure their contributions are reviewed by the article author. For example, if you work in CSS and only contribute occasionally, working in the public repository is lighter and easier for most docs contributions."

@jborsecnik
Copy link
Contributor

@mikeblome, okay. Can you sign off on this PR? Thanks.

@jborsecnik jborsecnik merged commit 5f1f1b3 into MicrosoftDocs:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged tracking label for the PR review team do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants