Skip to content

Migrate Visual Studio Installer Projects Docs from 2010 to Current #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rconard
Copy link

@rconard rconard commented Dec 6, 2019

This is our first step in modernizing the documentation for Visual Studio Installer Projects.

@PRMerger9
Copy link
Contributor

@rconard : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rconard
Copy link
Author

rconard commented Dec 6, 2019

@MSLukeWest, @SvetBonev, and @diverdan92, please review

@@ -0,0 +1,18 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this new page is necessary. IMO an overview of packaging technologies in VS doesn't need to be included in the installer projects docs. It would also be hard to get this page right, for example you'd have to mention technologies like ClickOnce, which certainly falls under the umbrella of "tools for packaging desktop applications for Windows".

You can download the extension here:
[Visual Studio Installer Projects](https://marketplace.visualstudio.com/items?itemName=VisualStudioClient.MicrosoftVisualStudio2017InstallerProjects)

## Update for .NET Core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more to say here, but it sounds like you want to address that in a follow up change.

@ShannonLeavitt ShannonLeavitt added the aq-pr-triaged tracking label for the PR review team label Dec 8, 2019
@ktoliver
Copy link
Contributor

ktoliver commented Dec 9, 2019

Hi @rconard - Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.

After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.

For more information, see Should I work in a private or a public repo?

If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.

Would you create a pull request in the private repo to make these updates? We'll close this PR. Thank you.

@ktoliver ktoliver closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants