Skip to content

AddDeleteInputFile #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

shahabhijeet
Copy link
Contributor

Adding a note for scenario when adding new files or deleting existing files does not update output.

Adding a note for scenario when adding new files or deleting existing files does not update output.
@PRMerger13
Copy link
Contributor

@shahabhijeet : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that this is more of a callout note: "Only the contents of the list in the current execution are considered. Changes in the list from the last build do not automatically make a target out of date."

@ghogen, thoughts?

@ghogen
Copy link
Collaborator

ghogen commented Feb 7, 2020

@shahabhijeet @rainersigwald
Let's close this one, but internally we will add a Note. I think the wording has to be very clear.

@ghogen
Copy link
Collaborator

ghogen commented Feb 7, 2020

Closing - thanks for pointing out this issue @shahabhijeet

@ghogen ghogen closed this Feb 7, 2020
@shahabhijeet
Copy link
Contributor Author

shahabhijeet commented Feb 12, 2020

@ghogen
Would you tell me what you mean by "internally we will add a Note", does that mean that note will not be reflected on the public docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants