Skip to content

Add link to recommended MSBuild Properties #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

vritant24
Copy link
Contributor

.runsettings File paths can be specified with an MSBuild property, but only the ones mentioned in the linked doc work in all cases.

.`runsettings` File paths can be specified with an MSBuild property, but only the ones mentioned in the linked doc work in all cases.
@PRMerger8
Copy link
Contributor

@vritant24 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9
Copy link
Contributor

@vritant24 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Mar 11, 2020
@ktoliver
Copy link
Contributor

Hi @Mikejo5000 - If the updates are approved, we can remove the locale from the URL before merging the PR.

Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@Mikejo5000
Copy link
Collaborator

@ktoliver That would be great if you can fix the URL. Let me know if you want me to sign off.

@PRMerger6
Copy link
Contributor

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6 PRMerger6 requested a review from Mikejo5000 March 11, 2020 21:00
@ktoliver
Copy link
Contributor

Thanks @Mikejo5000

I'll go ahead and merge the PR.

@ktoliver ktoliver merged commit e740653 into MicrosoftDocs:master Mar 11, 2020
@vritant24
Copy link
Contributor Author

Thanks for fixing the URL and the quick merge @ktoliver @Mikejo5000 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants