Skip to content

Fix markdown issues #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 98 commits into from
Aug 14, 2020
Merged

Fix markdown issues #5730

merged 98 commits into from
Aug 14, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 13, 2020 •
edited
Loading

No description provided.

@PRMerger9 PRMerger9 requested a review from Mikejo5000 August 13, 2020 12:16
@PRMerger9
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Youssef1313 Youssef1313 marked this pull request as draft August 13, 2020 12:16
@PRMerger9
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10 PRMerger10 requested a review from mavasani August 13, 2020 12:18
@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

1 similar comment
@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10
Copy link
Contributor

@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Youssef1313 Youssef1313 marked this pull request as ready for review August 13, 2020 14:59
@Youssef1313
Copy link
Member Author

There is still more to fix. Marking as ready for review to get an initial review. But it's not ready to merge yet.

@ktoliver ktoliver requested review from ghogen and removed request for carlossanlop, mavasani, jozkee, dotpaul and buyaa-n August 13, 2020 16:45
@ktoliver ktoliver added aq-pr-triaged tracking label for the PR review team and removed review-team-triage labels Aug 13, 2020
@ktoliver
Copy link
Contributor

@ghogen and @Mikejo5000 - Could you review this pull request? Thanks.

@ghogen
Copy link
Collaborator

ghogen commented Aug 13, 2020

@Youssef1313 Does this PR enable markdownlint for the repo? We discussed this internally a while back, and decided not to enable it, to avoid excessive randomization. I'd suggest holding off on any further work on this, unless that decision is changed.

@Youssef1313
Copy link
Member Author

@ghogen, Yes it enables it for the repo.
The workflow running on my fork detected actual problems on the live docs site. So, not all of the changes are just markdown stylish things.

Youssef1313
Youssef1313 commented Aug 13, 2020
View reviewed changes
docs/deployment/quickstart-deploy-to-azure.md
@@ -33,7 +33,7 @@ This article describes how to use the **Publish** tool for one-time deployment.

![Choose publish target](../deployment/media/quickstart-publish-azure-new.png)

1. Select **Azure App Service (Windows) **and **Next**.
1. Select **Azure App Service (Windows)** and **Next**.
Copy link
Member Author

@Youssef1313 Youssef1313 Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghogen This is one example where it affected how the text is actually rendered. Because of incorrect spacing, the asterisks appears on the live site instead of the text being bold.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youssef1313 OK, thanks. Could you remove the part that enables markdownlint, so we can just accept the other changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghogen I have deleted the part that enables the workflow for the repo.

@Youssef1313 Youssef1313 changed the title Create markdownlint.yml Fix markdown issues Aug 14, 2020
@ghogen ghogen merged commit 596c242 into MicrosoftDocs:master Aug 14, 2020
@Youssef1313 Youssef1313 deleted the patch-2 branch August 14, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghogen ghogen ghogen approved these changes

@Mikejo5000 Mikejo5000 Awaiting requested review from Mikejo5000

Assignees

@ghogen ghogen

@Mikejo5000 Mikejo5000

Labels
aq-pr-triaged tracking label for the PR review team change sent to author do-not-merge visual-studio-windows/prod vs-ide-code-analysis/tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.